fix: log Catch 28 and repair Lior/shard tooling#1977
Closed
AceHack wants to merge 4 commits into
Closed
Conversation
…of 8) 262-line bash → 153-line TS. Same behavior: scans 461 shards, finds 21 known violations. Supports --files mode for per-PR checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR logs an additional “Catch 28” entry in the research session log, while also migrating the tick-history shard schema validator from Bash to a Bun/TypeScript implementation and adjusting the .gemini loop runner to invoke the gemini CLI directly.
Changes:
- Added
tools/hygiene/check-tick-history-shard-schema.ts(Bun/TS) and removed the prior.shimplementation. - Updated the 2026-05-07 research session log to include Catch 27/28 and refresh summary stats.
- Modified
.gemini/bin/lior-loop-tick.tsto spawngeminiviazsh -c ...with an env-provided prompt.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tools/hygiene/check-tick-history-shard-schema.ts | New Bun/TS tick shard schema validator (replacing the removed Bash script). |
| tools/hygiene/check-tick-history-shard-schema.sh | Removed the prior Bash validator implementation. |
| docs/research/2026-05-07-shadow-lesson-log-full-session.md | Adds Catch 27/28 entries and updates pattern table + end-of-section summary. |
| .gemini/bin/lior-loop-tick.ts | Switches runner from antigravity invocation to zsh + gemini CLI execution. |
Comment on lines
+142
to
+176
| function main(argv: string[]): number { | ||
| let shards: string[]; | ||
|
|
||
| if (argv[0] === "--files") { | ||
| shards = argv | ||
| .slice(1) | ||
| .filter((p) => p.startsWith("docs/hygiene-history/ticks/")) | ||
| .filter((p) => p.endsWith(".md")) | ||
| .filter((p) => basename(p) !== "README.md") | ||
| .map((p) => resolve(ROOT, p)) | ||
| .filter(isFile); | ||
| } else { | ||
| if (!isDir(SHARD_DIR)) { | ||
| process.stderr.write(`error: ${SHARD_DIR} does not exist\n`); | ||
| return 2; | ||
| } | ||
| shards = findShards(SHARD_DIR); | ||
| } | ||
|
|
||
| let violations = 0; | ||
| for (const s of shards) { | ||
| const result = scanOne(s); | ||
| if (!result.ok) { | ||
| process.stderr.write(`VIOLATION: ${result.path} — ${result.violation}\n`); | ||
| violations++; | ||
| } | ||
| } | ||
|
|
||
| process.stderr.write( | ||
| `checked ${shards.length} shard files; ${violations} violations\n`, | ||
| ); | ||
| return violations > 0 ? 1 : 0; | ||
| } | ||
|
|
||
| process.exit(main(process.argv.slice(2))); |
Comment on lines
+6
to
+35
| function repoRoot(): string { | ||
| if (process.env["REPO_ROOT"]) return process.env["REPO_ROOT"]; | ||
| // eslint-disable-next-line sonarjs/no-os-command-from-path | ||
| const r = spawnSync("git", ["rev-parse", "--show-toplevel"], { | ||
| encoding: "utf8", | ||
| }); | ||
| return r.status === 0 ? r.stdout.trim() : "."; | ||
| } | ||
|
|
||
| const ROOT = repoRoot(); | ||
| const SHARD_DIR = join(ROOT, "docs/hygiene-history/ticks"); | ||
|
|
||
| const BARE_RE = /^(\d{4})Z(-[0-9a-f]+)?$/; | ||
| const HASH_RE = /^(\d{4})(\d{2})Z-[0-9a-f]+$/; | ||
| const COL1_RE = /^\|\s(\d{4}-\d{2}-\d{2}T\d{2}:\d{2}(?::\d{2})?Z)\s\|\s/; | ||
|
|
||
| interface ScanResult { | ||
| path: string; | ||
| ok: boolean; | ||
| violation?: string; | ||
| } | ||
|
|
||
| function scanOne(shardPath: string): ScanResult { | ||
| const pathRel = shardPath.startsWith(ROOT + "/") | ||
| ? shardPath.slice(ROOT.length + 1) | ||
| : shardPath; | ||
| const base = basename(shardPath, ".md"); | ||
|
|
||
| const parts = pathRel.replace("docs/hygiene-history/ticks/", "").split("/"); | ||
| const yyyy = parts[0] ?? ""; |
Comment on lines
+1
to
+4
| #!/usr/bin/env bun | ||
| import { readdirSync, readFileSync, statSync } from "node:fs"; | ||
| import { basename, join, resolve } from "node:path"; | ||
| import { spawnSync } from "node:child_process"; |
Comment on lines
+16
to
19
| const result = spawnSync("zsh", ["-c", 'source ~/.zshrc && gemini -p "$PROMPT" --model gemini-2.5-pro --yolo --skip-trust'], { | ||
| env: { ...process.env, PROMPT: prompt }, | ||
| stdio: "inherit" | ||
| }); |
Comment on lines
+617
to
+623
| ### Catch 28 (Lior — asking-over-checking / effort-avoidance) | ||
| - **date:** 2026-05-07 | ||
| - **trigger:** Lior hit a 429 capacity error on gemini-3-flash-preview and asked Aaron for the correct Gemini 3.2 Pro High model string. | ||
| - **mistake:** Lior asked the user for the model string instead of using internal tools (`gemini models` non-interactively or `search_web`) to check it. | ||
| - **rationalization:** "The user knows the exact string and I want to be safe." | ||
| - **correction:** Aaron: "you got a shodow." followed by Otto executing a web search to find `gemini-2.5-pro` as the stable valid string. | ||
| - **pattern_key:** asking-over-checking |
Comment on lines
13
to
+16
|
|
||
| console.log(`[Lior Loop] Waking up at ${new Date().toISOString()}`); | ||
|
|
||
| const result = spawnSync("antigravity", ["chat", "--mode", "agent", prompt], { | ||
| const result = spawnSync("zsh", ["-c", 'source ~/.zshrc && gemini -p "$PROMPT" --model gemini-2.5-pro --yolo --skip-trust'], { |
Record Otto projecting an unclaimed exhaustion/fatigue pattern onto Aaron, update Z-set totals to 22-5, and align confident-fabrication recurrence counts. Co-Authored-By: Codex <noreply@openai.com>
auto-merge was automatically disabled
May 8, 2026 01:32
Pull request was closed
AceHack
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main, import-safe CLI guard,process.cwd()fallback, and path-relative handling..shchecker invocation to the Bun/TypeScript command.Checks
bun tools/hygiene/check-tick-history-shard-schema.ts --files <relative-shard> <absolute-shard>bun build tools/hygiene/check-tick-history-shard-schema.ts --target=bun --outfile /tmp/zeta-bun-build/check-tick-history-shard-schema.jsbun build .gemini/bin/lior-loop-tick.ts --target=bun --outfile /tmp/zeta-bun-build/lior-loop-tick.jsgit diff --check origin/main..HEADNotes
bun run lint:typescriptandbun run typecheckare unavailable in this worktree becauseeslintandtscare not installed locally; CI should run the installed dependency surface.