Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did the PR do
The PR corrects the
wholeMatch
function, making it work effectively and more efficiently. The addon can self-recommendation as expected now.Why do so
The doc recommends writing
words
inconfig.json
like this:Most addon authors captured the require string in the doc. However, a commit three years ago (
f4e4cc0114adba8d199f9f81298a7c15c9576d5c
) modified the code from:to
Unfortunately, if the pattern word itself has captures (similar to the doc example),
pos2
will return a string instead of a number. Consequently, the whole self-recommend feature hasn't worked for the past three years.