Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

say hello does not make helix happy - #40fd1d7 #2797

Closed
yavorski opened this issue Aug 14, 2024 · 1 comment · Fixed by #2798
Closed

say hello does not make helix happy - #40fd1d7 #2797

yavorski opened this issue Aug 14, 2024 · 1 comment · Fixed by #2798
Labels
bug Something isn't working

Comments

@yavorski
Copy link

How are you using the lua-language-server?

Other

Which OS are you using?

Linux

What is the issue affecting?

Annotations, Type Checking, Completion, Diagnostics/Syntax Checking, Hover, Libraries, Formatting, Spell Checking, Plugins, Other

Expected Behaviour

Server should start correctly.

Actual Behaviour

Hi, after this commit 40fd1d7 lua-language-server fails to start in helix-editor and directly exit with error.
Here is the discussion helix-editor/helix#11472 for more info and this comment specifically explain why that is.
Can someone elaborate on why it is needed, or is it feasible to make it valid JSONRPC?
Thank you!

Reproduction steps

Just open any lua file with helix and latest lua-language-server installed,

Additional Notes

Thank you very much for helping improve the language server!

Log File

No response

@CppCXY CppCXY added the bug Something isn't working label Aug 15, 2024
@tomlau10
Copy link
Contributor

(Off topic)
Strange enough, the description of #2798 has mentioned it will close this issue, but github doesn't automatically link the two? 😳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants