Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlighting doesnt work #3

Closed
aMOPel opened this issue Apr 15, 2021 · 5 comments
Closed

highlighting doesnt work #3

aMOPel opened this issue Apr 15, 2021 · 5 comments
Assignees
@LoricAndre
Labels
bug Something isn't working

Comments

@aMOPel
Copy link

aMOPel commented Apr 15, 2021

with fzf.vim plugin and ":Ag", also using bat in PATH for preview
Screenshot from 2021-04-15 22-33-13
With :OneTerm ag
Screenshot from 2021-04-15 22-33-26
@LoricAndre LoricAndre self-assigned this Apr 15, 2021
@LoricAndre LoricAndre added the bug Something isn't working label Apr 15, 2021
@LoricAndre
Copy link
Owner

This is probably due to how I highlight the search result in the preview buffer, I'll take a look

@aMOPel
Copy link
Author

aMOPel commented Apr 15, 2021

oh i actually get preview highlighting with :OneTerm lines

@LoricAndre
Copy link
Owner

Yes, it's specific to rg and ag I think, I don't have the code with me rn so I can't say for sure

@LoricAndre LoricAndre mentioned this issue Apr 15, 2021
Open
@aMOPel
Copy link
Author

aMOPel commented Apr 15, 2021

but also the highlighting in the fzf windows is kinda missing, not just the preview windows, without the matches are harder to read.
also for :OneTerm commits for example

@LoricAndre
Copy link
Owner

This is foxed in the last few commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LoricAndre LoricAndre

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aMOPel @LoricAndre