Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<iframe> Support #33

Open
A-Paterson opened this issue Aug 28, 2024 · 2 comments
Open

<iframe> Support #33

A-Paterson opened this issue Aug 28, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@A-Paterson
Copy link
Contributor

Currently, Net Doc breaks if embedded in an <iframe> tag, which has caused problems with the Net Doc Desktop tabs implementation and means it can't be embedded in Teams.

@A-Paterson A-Paterson changed the title <iframe> Support <iframe> Support Aug 28, 2024
@Arcath Arcath added this to the Version Next milestone Aug 28, 2024
@Arcath Arcath added the enhancement New feature or request label Aug 28, 2024
@Arcath Arcath modified the milestones: Version Next, Version 2.2 Oct 19, 2024
@Arcath
Copy link
Contributor

Arcath commented Oct 25, 2024

Was this a CORS issue? Might be something we can fix with the nginx revese proxy we use after #42

@A-Paterson
Copy link
Contributor Author

The console shows this:

Request URL: https://docs.lhs.lancs.sch.uk/app
Request Method: GET
Status Code: 403 Forbidden
Remote Address: 20.199.107.83:443
Referrer Policy: strict-origin-when-cross-origin
Request URL: https://docs.lhs.lancs.sch.uk/app/login
Request Method: POST
Status Code: 302 Found
Remote Address: 20.199.107.83:443
Referrer Policy: strict-origin-when-cross-origin

A warning has appeared next to the cookie in the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants