Edit Mode GUI as a ToolbarOverlay #390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* EditorModeOverlay: a ToolbarOverlay that offers the same functionality as the Edit Mode GUI found before; plus a button to toggle Realtime CSG On/Off. * Icons for each edit mode Modified * CSGSettings: added a static Action iinvoked when EnableRealtimeCSG value changes. * EditModeManager: Added an Action invoked when the EditMode changes. Added a static property to access it from other classes. * EditModeSelection.GUI: surrounded the display of the former Area by #if !UNITY_2021_3_OR_NEWER so it isn't displayed beyond this version * CSG_GUIStyleUtility: move the initialization of BrushEditModeContent and brushEditModeTooltips in a separate static function, so they can be called separately and used from EditorModeOverlay.
…ue on OverlayTab doesn't seem to have any effect.
|
@nukeandbeans so this is my first time going though a pull request process, is there anything I need to do on my end at this point? |
|
Hey! Apologies on taking a bit to get back to you. There isn't much for you to do yet. I need to test and verify it doesn't break things in branches of existing projects, though I'm not completely certain how soon I'll be able to at the moment. Your work so far looks fantastic, though! Thanks for the PR! |
|
Hello and happy new year- any update on this ? |
|
@nukeandbeans Another ping on this, just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes makes it that, if the project is using Unity 2021 or newer, the Edit Mode GUI is not rendered and an OverlayTab is shown instead.
Tested in 2020.3, 2021.3 and 2022.3. Though in 2021, the defaultDisplay flag to show the OverlayTab in new Scene editor, doesn't seem to work.
I'd argue this is a good first step to submit vs. waiting for all tool GUI to be ported to the OverlayTab: it makes the first time UX a lot more digestible and remove the conflict of the old UX that was stuck in a corner and was displayed below the Overlay for general manipulation.
Added:
Modified