This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Improvements on Dockerfile - Closes #889 #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed bower and nasm - Use of COPY with --chown argument - Use npm ci instead of npm install - Added stage to install dependencies before copy source code, so the layer with deps can be cached.
fchavant
changed the title
fchavant
reviewed
Feb 6, 2019
fchavant
approved these changes
Feb 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
layer with deps can be cached.
What was the problem?
How did I fix it?
How to test it?
Review checklist
commit guidelines