Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Show only positive numbers for the transaction pagination - #859 #872

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Show only positive numbers for the transaction pagination - #859 #872

merged 1 commit into from
Dec 20, 2018

Conversation

youxiberlin
Copy link
Contributor

What was the problem?

  • It showed negative numbers on the pagination at Transaction when the transactions had only 1 page.

How did I fix it?

  • Add a filter to a pagination function and made it show only positive numbers.

How to test it?

  • Checked on the browser.

Review checklist

  • The PR solves General UI update #859
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the
    commit guidelines
  • Documentation has been added/updated

@MichalTuleja MichalTuleja merged commit df207d7 into 2.2.0 Dec 20, 2018
@MichalTuleja MichalTuleja deleted the 859-txs-pagination-filter branch December 20, 2018 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalTuleja MichalTuleja MichalTuleja approved these changes

Assignees

@MichalTuleja MichalTuleja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youxiberlin @MichalTuleja