Default values for search - Closes #254 #255

reyraa · 2017-08-14T11:08:44Z

In Client: If neither of senderId or recipientId are defined, we set the page address Id to both.
In Api: If the senderId and RecipientId are the same, we'll make 2 Api calls and merge the results.

Closes #254

Set default sender and recipient IDs

e6f3036

reyraa self-assigned this Aug 14, 2017

reyraa requested a review from Isabello August 14, 2017 11:08

reyraa added enhancement pending review labels Aug 14, 2017

reyraa force-pushed the 254-default-values-for-search branch from d182579 to d778587 Compare August 14, 2017 11:13

Create second Api call for equal sender and recipient IDs

3b95c1e

reyraa force-pushed the 254-default-values-for-search branch from d778587 to 3b95c1e Compare August 14, 2017 11:20

Fix key type checking in search box

df96c64

reyraa force-pushed the 254-default-values-for-search branch from 6b5174e to df96c64 Compare August 14, 2017 13:34

Fix race condition in Api calls responses

7cbfb2c

4miners approved these changes Aug 14, 2017

View reviewed changes

4miners merged commit a3057bd into 1.3.0 Aug 14, 2017

4miners added ready and removed pending review labels Aug 14, 2017

karmacoma removed bug enhancement regression test labels Aug 15, 2017

reyraa deleted the 254-default-values-for-search branch August 24, 2017 11:17

baby636 mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities baby636/lisk-explorer#30

Open

baby636 mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities baby636/lisk-explorer#35

Open

baby636 mentioned this pull request Nov 27, 2023

[Snyk] Fix for 24 vulnerabilities baby636/lisk-explorer#43

Open

Provide feedback