Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Add validation before signing for transaction - Closes #532 #641

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

shuse2
Copy link
Contributor

@shuse2 shuse2 commented Nov 5, 2018

What was the problem?

When signing the transaction, user was able to sign invalid transaction.
However, invalid transaction should not be tried to sign.

How did I fix it?

How to test it?

./bin/run transaction:sign '{ type: 0 }'

Review checklist

@shuse2 shuse2 self-assigned this Nov 5, 2018
@shuse2 shuse2 requested a review from mitsuaki-u November 5, 2018 17:11
@shuse2 shuse2 changed the base branch from 638-upgrade_lisk_elements to release/2.0.0 November 6, 2018 07:59
@shuse2 shuse2 changed the title Add validation before signing for transaction:sign Add validation before signing for transaction - Closes #532 Nov 7, 2018
@shuse2 shuse2 merged commit 303561c into release/2.0.0 Nov 9, 2018
@shuse2 shuse2 deleted the 532-validate_tx_before_sign branch November 9, 2018 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants