-
Notifications
You must be signed in to change notification settings - Fork 30
Fix wrong transaction number on create delegate and vote transactions - Closes #633 #634
Conversation
@@ -55,36 +55,75 @@ describe('transaction:create', () => { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also switch order in imports and setupTest
defintion for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also minor fix for test/commands/transaction/create/vote.test.js (not in this PR but might as well fix here): Test title transaction:create:transfer
should be transaction:create:vote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test title
@@ -55,36 +55,75 @@ describe('transaction:create', () => { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also minor fix for test/commands/transaction/create/vote.test.js (not in this PR but might as well fix here): Test title transaction:create:transfer
should be transaction:create:vote
What was the problem?
transaction:create -t=2 and -t=3 was resulting in opposite transaction
How did I fix it?
Switch the transaction type between 2 and 3
How to test it?
and check type 2 results in delegate registration transaction and type 3 in vote transaction
Review checklist