Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Fix wrong transaction number on create delegate and vote transactions - Closes #633 #634

Merged
merged 3 commits into from
Oct 25, 2018

Conversation

shuse2
Copy link
Contributor

@shuse2 shuse2 commented Oct 24, 2018

What was the problem?

transaction:create -t=2 and -t=3 was resulting in opposite transaction

How did I fix it?

Switch the transaction type between 2 and 3

How to test it?

npm run build
npm t
./bin/run transaction:create =t=2
./bin/run transaction:create =t=3

and check type 2 results in delegate registration transaction and type 3 in vote transaction

Review checklist

@shuse2 shuse2 self-assigned this Oct 24, 2018
@shuse2 shuse2 requested a review from mitsuaki-u October 24, 2018 14:22
@@ -55,36 +55,75 @@ describe('transaction:create', () => {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also switch order in imports and setupTest defintion for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also minor fix for test/commands/transaction/create/vote.test.js (not in this PR but might as well fix here): Test title transaction:create:transfer should be transaction:create:vote

Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test title

@@ -55,36 +55,75 @@ describe('transaction:create', () => {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also minor fix for test/commands/transaction/create/vote.test.js (not in this PR but might as well fix here): Test title transaction:create:transfer should be transaction:create:vote

@shuse2 shuse2 merged commit 55d1469 into release/2.0.0 Oct 25, 2018
@shuse2 shuse2 deleted the 633-fix_transaction_number branch October 25, 2018 09:46
@shuse2 shuse2 changed the title Fix wrong transaction number on create delegate and vote transactions Fix wrong transaction number on create delegate and vote transactions - Closes #633 Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants