This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Remove Darwin specific logic - Closes #317 #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelboldu
previously approved these changes
Aug 7, 2018
Nazgolze
reviewed
Aug 9, 2018
build.sh
Outdated
| @@ -59,10 +59,7 @@ cd src || exit 2 | |||
|
|
|||
| echo "Building libreadline7" | |||
| echo "--------------------------------------------------------------------------" | |||
| if [ ! -f "$LIBREADLINE_FILE" ] && [ ! "$(uname -s)" == "Darwin" ]; then | |||
| exec_cmd "wget $LIBREADLINE_URL -O $LIBREADLINE_FILE" | |||
fchavant
force-pushed
the
317-discontinue-darwin-buils
branch
from
e393460 to
19eef3b
Compare
Nazgolze
approved these changes
Aug 9, 2018
Nazgolze
previously requested changes
Aug 9, 2018
fchavant
force-pushed
the
317-discontinue-darwin-buils
branch
from
19eef3b to
fb077c3
Compare
Nazgolze
previously requested changes
Aug 9, 2018
build.sh
Outdated
| @@ -151,10 +144,6 @@ if [ ! -d "$BUILD_NAME/node_modules" ]; then | |||
| # Copy jq to binary folder | |||
| exec_cmd "cp -vf $JQ_DIR/$JQ_OUT $BUILD_NAME/bin/$JQ_OUT" | |||
|
|
|||
| if [ ! "$(uname -s)" == "Darwin" ]; then | |||
| exec_cmd "cp -vf $LIBREADLINE_DIR/out/lib/* $BUILD_NAME/lib" | |||
There was a problem hiding this comment.
This one too. This is all of them
fchavant
force-pushed
the
317-discontinue-darwin-buils
branch
from
fb077c3 to
d303b37
Compare
Nazgolze
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.