Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppStore won't let upload the binary using LiquidCore #180

Closed
dsemenovsky opened this issue May 25, 2020 · 3 comments · Fixed by #181
Closed

AppStore won't let upload the binary using LiquidCore #180

dsemenovsky opened this issue May 25, 2020 · 3 comments · Fixed by #181

Comments

@dsemenovsky
Copy link
Contributor

ITMS-90338: Non-public API usage - The app references non-public symbols in Frameworks/LiquidCore.framework/LiquidCore: _getcontext, _makecontext, _setcontext. If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions. In addition, note that one or more of the above APIs may be located in a static library that was included with your app. If so, they must be removed. For further information, visit the Technical Support Information at

@KGMaxey
Copy link

KGMaxey commented May 29, 2020

Can confirm this issue

@KGMaxey
Copy link

KGMaxey commented Jun 1, 2020

Update: as a workaround until this PR get's approved, adding this to your pod file appears to work. It's the same fix as the PR just post install.

post_install do |installer|
  installer.pods_project.targets.each do |target|
    if target.name == "LiquidCore"
      print "Found LiquidCore Target. Updating CFLAGS...\n"
      target.build_configurations.each do |config|
        cflags = config.build_settings['OTHER_CFLAGS'] || ['$(inherited)']
        cflags << '-DOPENSSL_NO_ASYNC'
        config.build_settings['OTHER_CFLAGS'] = cflags
      end
    end
  end
end

@ericwlange
Copy link
Member

Thanks for the contribution! This has been merged and released in 0.7.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants