Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with react-on-rails npm package #20

Closed
teameh opened this issue Apr 7, 2017 · 3 comments
Closed

Fix incompatibility with react-on-rails npm package #20

teameh opened this issue Apr 7, 2017 · 3 comments

Comments

@teameh
Copy link
Contributor

teameh commented Apr 7, 2017

react-on-rails moved away from hidden divs..

Use <script type="application/json"> for props and store instead of hidden div #775

this bundle needs to be updated as well..

(I might be able to work on this next week if you like)

@teameh
Copy link
Contributor Author

teameh commented Apr 7, 2017

(I might be able to work on this next week if you like) working on a proposal now.

@teameh
Copy link
Contributor Author

teameh commented Apr 7, 2017

Haha oh sorry, I wasn't aware of the separation of the renderer into its own package. Made a PR here Limenius/ReactRenderer#1

@nacmartin
Copy link
Member

Thanks! included in v0.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants