feat: Enhance JobCreatorController to manage single job lifecycle #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify JobCreatorController to track a single job via jobID - Update job offer and deal event handling to filter by specific job - Improve result checking and processing with more robust error handling - Remove deprecated job offer subscription filter method - Simplify job tracking and event subscription logic
hollygrimm
changed the title
bgins
approved these changes
Mar 7, 2025
| return controller.SubscribeToJobOfferUpdatesWithFilter(sub, "") | ||
| // Set the controller's jobID to track this specific job | ||
| controller.jobID = container.JobOffer.ID | ||
| controller.log.Debug("Set controller jobID", map[string]interface{}{ |
There was a problem hiding this comment.
nit: Have been seeing modernization suggestions in my editor recently:
modernize: interface{} can be replaced by any
Looks like go added an any to use instead of interface{}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the following changes:
By isolating job output, tools like the Discord Observer can run jobs in parallel and get the appropriate job output.
Task/Issue reference
Closes: 412
Test plan
Start the stack. Run the integration tests: ./stack integration-tests
Run a job and compare the logs in the cli with the logs in this pull request.