Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Change serve sanity check default to False #447

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Serve currently doesn't work from a notebook so the sanity check will fail. This changes the default to false so that the sanity check won't run unless requested

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #447 (05b8835) into master (882e204) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files         112      112           
  Lines        7065     7065           
=======================================
  Hits         6476     6476           
  Misses        589      589           
Flag Coverage Δ
unittests 91.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/trainer.py 87.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882e204...05b8835. Read the comment docs.

@ethanwharris ethanwharris merged commit 2ec52e6 into master Jun 22, 2021
@ethanwharris ethanwharris deleted the sanity_check_default branch June 22, 2021 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant