Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

The test step should not use the same metrics objects as validation #843

Closed
carmocca opened this issue Oct 8, 2021 · 1 comment · Fixed by #900
Closed

The test step should not use the same metrics objects as validation #843

carmocca opened this issue Oct 8, 2021 · 1 comment · Fixed by #900
Labels
bug / fix Something isn't working help wanted Extra attention is needed

Comments

@carmocca
Copy link
Contributor

carmocca commented Oct 8, 2021

@carmocca carmocca added bug / fix Something isn't working help wanted Extra attention is needed labels Oct 8, 2021
@ethanwharris
Copy link
Collaborator

ethanwharris commented Oct 8, 2021

We do a deepcopy of the metrics object here: https://github.com/PyTorchLightning/lightning-flash/blob/eb1fcd3925ee297d08704d48c5fc57624665ad96/flash/core/model.py#L335 We could add something to do the same for test too. Simple test for correctness here that should be expanded to include val and test: https://github.com/PyTorchLightning/lightning-flash/blob/eb1fcd3925ee297d08704d48c5fc57624665ad96/tests/core/test_model.py#L345

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working help wanted Extra attention is needed
Projects
None yet
2 participants