Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

from_csv or from_df method in ImageClassificationData #257

Closed
aniketmaurya opened this issue May 2, 2021 · 3 comments · Fixed by #556
Closed

from_csv or from_df method in ImageClassificationData #257

aniketmaurya opened this issue May 2, 2021 · 3 comments · Fixed by #556
Assignees
Labels
API / design enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@aniketmaurya
Copy link
Contributor

🚀 Feature

Currently, ImageClassificationData has only from_folder and from_filepaths method. It would be helpful to have from_df or from_csv as well.

Motivation

I was trying out https://www.kaggle.com/c/plant-pathology-2021-fgvc8/overview and the data is present in CSV format.

Additional context

PS: I would like to contribute to this.

@aniketmaurya aniketmaurya added enhancement New feature or request help wanted Extra attention is needed labels May 2, 2021
@edgarriba
Copy link
Contributor

the DataModule API is under refactor in #256. After that I guess we can include methods like the ones you suggest. However, that api needs a bit of though since data coming dataframes or csv files can be in infinite formats and structures. /cc @ethanwharris

@ethanwharris
Copy link
Collaborator

Hi all, yeah best to leave this one until #256 is finished (hopefully won't be long). I agree with @edgarriba, but I think we should at least be able to provide some defaults for image and text classification - one field corresponds to the text / image file to classify, one or more fields (for multi-label) correspond to the target/s. That should be pretty easy to add with #256 😃

@aniketmaurya
Copy link
Contributor Author

I agree @ethanwharris! We should atleast capture default cases and may be provide some method to customise it may be by passing a function to load CSV and return X and Y values.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API / design enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants