Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

The type of n_gram is mislabeled as bool, which should be int type. #1485

Closed
BrightXiaoHan opened this issue Nov 16, 2022 · 0 comments · Fixed by #1486
Closed

The type of n_gram is mislabeled as bool, which should be int type. #1485

BrightXiaoHan opened this issue Nov 16, 2022 · 0 comments · Fixed by #1486
Labels
bug / fix Something isn't working help wanted Extra attention is needed

Comments

@BrightXiaoHan
Copy link
Contributor

🐛 Bug

In Translation Task:
The type of n_gram is mislabeled as bool, which should be int type.

To Reproduce

flash translation from_hf_datasets --help

The error raised:

translation: error: Configuration check failed :: Parser key "model.n_gram": Expected a <class 'bool'> but got "4"
@BrightXiaoHan BrightXiaoHan added bug / fix Something isn't working help wanted Extra attention is needed labels Nov 16, 2022
@BrightXiaoHan BrightXiaoHan mentioned this issue Nov 16, 2022
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug / fix Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix type of 'n_gram' from bool to int in TranslationTask BrightXiaoHan/lightning-flash
1 participant
@BrightXiaoHan