From 3c8646d3bcac683096fb7385a4313e4ba241dc13 Mon Sep 17 00:00:00 2001 From: Jirka Date: Sun, 14 May 2023 20:07:52 +0200 Subject: [PATCH] todos --- .../classification/test_data_model_integration.py | 3 +-- tests/tabular/classification/test_model.py | 6 +++--- tests/tabular/regression/test_data_model_integration.py | 9 +++------ tests/tabular/regression/test_model.py | 6 +++--- 4 files changed, 10 insertions(+), 14 deletions(-) diff --git a/tests/tabular/classification/test_data_model_integration.py b/tests/tabular/classification/test_data_model_integration.py index f52f045830..074f9564dd 100644 --- a/tests/tabular/classification/test_data_model_integration.py +++ b/tests/tabular/classification/test_data_model_integration.py @@ -39,8 +39,7 @@ ("fttransformer", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), ("autoint", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), ("node", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), - # ("category_embedding", # todo: seems to be bug in tabular - # {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), + ("category_embedding", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), # No categorical / numerical fields ("tabnet", {"categorical_fields": ["category"]}), ("tabnet", {"numerical_fields": ["scalar_a", "scalar_b"]}), diff --git a/tests/tabular/classification/test_model.py b/tests/tabular/classification/test_model.py index 008a797a99..a42d07b422 100644 --- a/tests/tabular/classification/test_model.py +++ b/tests/tabular/classification/test_model.py @@ -55,7 +55,7 @@ class TestTabularClassifier(TaskTester): {"backbone": "fttransformer"}, {"backbone": "autoint"}, {"backbone": "node"}, - # {"backbone": "category_embedding"}, # todo: seems to be bug in tabular + {"backbone": "category_embedding"}, ], ) ], @@ -68,7 +68,7 @@ class TestTabularClassifier(TaskTester): {"backbone": "fttransformer"}, {"backbone": "autoint"}, {"backbone": "node"}, - # {"backbone": "category_embedding"}, # todo: seems to be bug in tabular + {"backbone": "category_embedding"}, ], ) ], @@ -81,7 +81,7 @@ class TestTabularClassifier(TaskTester): {"backbone": "fttransformer"}, {"backbone": "autoint"}, {"backbone": "node"}, - # {"backbone": "category_embedding"}, # todo: seems to be bug in tabular + {"backbone": "category_embedding"}, ], ) ], diff --git a/tests/tabular/regression/test_data_model_integration.py b/tests/tabular/regression/test_data_model_integration.py index 0a01bac532..9aff8a806e 100644 --- a/tests/tabular/regression/test_data_model_integration.py +++ b/tests/tabular/regression/test_data_model_integration.py @@ -48,8 +48,7 @@ ("fttransformer", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), ("autoint", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), ("node", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), - # ("category_embedding", # todo: seems to be bug in tabular - # {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), + ("category_embedding", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), # No categorical / numerical fields ("tabnet", {"categorical_fields": ["category"]}), ("tabnet", {"numerical_fields": ["scalar_a", "scalar_b"]}), @@ -82,8 +81,7 @@ def test_regression_data_frame(backbone, fields, tmpdir): ("fttransformer", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), ("autoint", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), ("node", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), - # ("category_embedding", # todo: seems to be bug in tabular - # {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), + ("category_embedding", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), # No categorical / numerical fields ("tabnet", {"categorical_fields": ["category"]}), ("tabnet", {"numerical_fields": ["scalar_a", "scalar_b"]}), @@ -113,8 +111,7 @@ def test_regression_dicts(backbone, fields, tmpdir): ("fttransformer", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), ("autoint", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), ("node", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), - # ("category_embedding", # todo: seems to be bug in tabular - # {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), + ("category_embedding", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}), # No categorical / numerical fields ("tabnet", {"categorical_fields": ["category"]}), ("tabnet", {"numerical_fields": ["scalar_a", "scalar_b"]}), diff --git a/tests/tabular/regression/test_model.py b/tests/tabular/regression/test_model.py index 52dd36ed9b..31674b2847 100644 --- a/tests/tabular/regression/test_model.py +++ b/tests/tabular/regression/test_model.py @@ -53,7 +53,7 @@ class TestTabularRegressor(TaskTester): {"backbone": "fttransformer"}, {"backbone": "autoint"}, {"backbone": "node"}, - # {"backbone": "category_embedding"}, # todo: seems to be bug in tabular + {"backbone": "category_embedding"}, ], ) ], @@ -66,7 +66,7 @@ class TestTabularRegressor(TaskTester): {"backbone": "fttransformer"}, {"backbone": "autoint"}, {"backbone": "node"}, - # {"backbone": "category_embedding"}, # todo: seems to be bug in tabular + {"backbone": "category_embedding"}, ], ) ], @@ -79,7 +79,7 @@ class TestTabularRegressor(TaskTester): {"backbone": "fttransformer"}, {"backbone": "autoint"}, {"backbone": "node"}, - # {"backbone": "category_embedding"}, # todo: seems to be bug in tabular + {"backbone": "category_embedding"}, ], ) ],