diff --git a/.github/actions/pkg-install/action.yml b/.github/actions/pkg-install/action.yml index 49e6c784..66b4cbf9 100644 --- a/.github/actions/pkg-install/action.yml +++ b/.github/actions/pkg-install/action.yml @@ -17,7 +17,7 @@ inputs: description: "additional pip install flags" required: false default: "-f https://download.pytorch.org/whl/cpu/torch_stable.html" - import-extras: + custom-import: description: "additional import statement, need to be full python code" required: false default: "" @@ -53,7 +53,7 @@ runs: run: | set -ex python -c "import ${{ inputs.import-name }} as pkg; print(f'version: {pkg.__version__}')" - python -c '${{ inputs.import-extras }}' + python -c '${{ inputs.custom-import }}' shell: bash - name: Uninstall all @@ -76,5 +76,5 @@ runs: run: | set -ex python -c "import ${{ inputs.import-name }} as pkg; print(f'version: {pkg.__version__}')" - python -c '${{ inputs.import-extras }}' + python -c '${{ inputs.custom-import }}' shell: bash diff --git a/.github/workflows/check-package.yml b/.github/workflows/check-package.yml index fc3e5d5c..dc8f0350 100644 --- a/.github/workflows/check-package.yml +++ b/.github/workflows/check-package.yml @@ -25,7 +25,7 @@ on: description: "Import name to test with after installation" required: true type: string - import-extras: + custom-import: description: "additional import statement, need to be full python code" type: string required: false @@ -131,7 +131,7 @@ jobs: pkg-extras: ${{ inputs.install-extras }} pip-flags: ${{ inputs.install-flags }} import-name: ${{ inputs.import-name }} - import-extras: ${{ inputs.import-extras }} + custom-import: ${{ inputs.custom-import }} # TODO: add run doctests diff --git a/.github/workflows/ci-use-checks.yaml b/.github/workflows/ci-use-checks.yaml index 9cadbf1e..3dd7ef69 100644 --- a/.github/workflows/ci-use-checks.yaml +++ b/.github/workflows/ci-use-checks.yaml @@ -64,7 +64,7 @@ jobs: install-extras: "[cli]" # todo: when we have a module with depence on extra, replace it # tried to import `lightning_utilities.cli.__main__` but told me it does not exits - import-extras: "import fire" + custom-import: "import fire" testing-matrix: | { "os": ["ubuntu-22.04", "macos-12", "windows-2022"], diff --git a/CHANGELOG.md b/CHANGELOG.md index 245cdb2a..d6ebe920 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 --- +## [UnReleased] - 2024-MM-DD + +### Changed + +- CI: rename `import-extras` to `custom-import` in package check ([#287](https://github.com/Lightning-AI/utilities/pull/287)) + ## [0.11.4] - 2024-07-15 ### Changed