Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create lightning_utilities.testing subpackage #45

Closed
1 of 3 tasks
akihironitta opened this issue Sep 8, 2022 · 5 comments
Closed
1 of 3 tasks

Create lightning_utilities.testing subpackage #45

akihironitta opened this issue Sep 8, 2022 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@akihironitta
Copy link
Contributor

akihironitta commented Sep 8, 2022

🚀 Feature

Collect common classes, functions, e.g.

Motivation

Prevents duplication across repositories.

@akihironitta akihironitta added enhancement New feature or request help wanted Extra attention is needed labels Sep 8, 2022
@akihironitta akihironitta changed the title Add lightning_utilities.testing subpackage Create lightning_utilities.testing subpackage Sep 8, 2022
@Borda
Copy link
Member

Borda commented Sep 8, 2022

@carmocca still thinking about having the RunIf as a prototype with some simple functionality which would be extended/inherit in particular projects like PL

@carmocca
Copy link
Contributor

carmocca commented Sep 8, 2022

What simple functionality? Only min_python and skip_windows don't require any packages. And the code deduplication will be almost nothing because each repo will need to rewrite its own.

@carmocca
Copy link
Contributor

carmocca commented Oct 3, 2022

I added #55 but haven't updated the projects to use it.

@Borda Borda closed this as completed Oct 5, 2022
@Borda
Copy link
Member

Borda commented Mar 1, 2023

I found with cutting strategies and accelerators that I am always coping with GPU, standalone, min torch, etc.

@Borda Borda mentioned this issue Mar 1, 2023
4 tasks
@carmocca
Copy link
Contributor

carmocca commented Mar 1, 2023

What's the issue with copying it? It's very simple infrastructure. If you wanted to share code, then it should be done through fabric or pytorch lightning, which do install torch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants