Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA for docs link check #124

Closed
Borda opened this issue Mar 16, 2023 · 0 comments · Fixed by #162
Closed

GHA for docs link check #124

Borda opened this issue Mar 16, 2023 · 0 comments · Fixed by #162
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Borda
Copy link
Member

Borda commented Mar 16, 2023

🚀 Feature

Motivation

As we moved in several projects to have link validation (detecting dead links) as optional, so if failed job still passes, it is almost as if it is not there because people will ignore it, so have an action that would parse and comment on PR with dead/broken links

Alternatives

make the link check again as required, and part of our build

Additional context

see: Lightning-AI/torchmetrics#1626 (comment)
@Borda Borda added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 16, 2023
@stale stale bot added the won't fix label Jun 18, 2023
@Lightning-AI Lightning-AI deleted a comment from stale bot Jun 18, 2023
@stale stale bot removed the won't fix label Jun 18, 2023
@stale stale bot added the won't fix label Sep 17, 2023
@Lightning-AI Lightning-AI deleted a comment from stale bot Sep 17, 2023
@Borda Borda mentioned this issue Sep 15, 2023
Merged
3 tasks
@stale stale bot removed the won't fix label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: unify docs makes flows Lightning-AI/utilities
1 participant
@Borda