Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing for kwargs #1078

Merged
merged 3 commits into from
Jun 8, 2022
Merged

typing for kwargs #1078

merged 3 commits into from
Jun 8, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 7, 2022

What does this PR do?

Not sure if I miss something, but maybe we have wrong the typing for kwargs as the Dict[str, Any] is meant for the structure, so each element is Any
I came to this thinking while fixing typing for #1069
See for reference: Type annotations for *args and **kwargs

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Jun 7, 2022
@Borda Borda marked this pull request as ready for review June 7, 2022 20:04
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1078 (b04971b) into master (0a5d964) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1078   +/-   ##
======================================
  Coverage      95%     95%           
======================================
  Files         181     181           
  Lines        8085    8085           
======================================
  Hits         7654    7654           
  Misses        431     431           

@Borda Borda enabled auto-merge (squash) June 7, 2022 20:29
@mergify mergify bot added the ready label Jun 8, 2022
@Borda Borda disabled auto-merge June 8, 2022 06:49
@Borda Borda merged commit 65594f1 into master Jun 8, 2022
@Borda Borda deleted the typing/kwargs branch June 8, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants