Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hinge losses #89

Closed
SkafteNicki opened this issue Mar 16, 2021 · 2 comments · Fixed by #120
Closed

Add Hinge losses #89

SkafteNicki opened this issue Mar 16, 2021 · 2 comments · Fixed by #120
Assignees
@ethanwharris
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed New metric

Comments

@SkafteNicki
Copy link
Member

🚀 Feature

Add Hinge losses to classification package:
https://scikit-learn.org/stable/modules/generated/sklearn.metrics.hinge_loss.html#sklearn.metrics.hinge_loss
possibly with an added parameter squared to also calculated squared hinge loss

Motivation

Pitch

Alternatives

Additional context
@SkafteNicki SkafteNicki added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed New metric labels Mar 16, 2021
@ethanwharris
Copy link
Member

Hi @SkafteNicki, I'd like to take a look at adding hinge_loss to torchmetrics :) Could you assign me to the issue?

@SkafteNicki
Copy link
Member Author

@ethanwharris Nice, thanks for wanting to contribute :]

@ethanwharris ethanwharris mentioned this issue Mar 22, 2021
Merged
4 tasks
@Borda Borda changed the title [New Metric] Hinge losses Add Hinge losses Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanwharris ethanwharris

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed New metric
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Hinge metric ethanwharris/metrics
2 participants
@ethanwharris @SkafteNicki