Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't make us specify the number of outputs for R2Score #2703

Closed
profPlum opened this issue Aug 29, 2024 · 1 comment · Fixed by #2705
Closed

Please don't make us specify the number of outputs for R2Score #2703

profPlum opened this issue Aug 29, 2024 · 1 comment · Fixed by #2705
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@profPlum
Copy link

profPlum commented Aug 29, 2024

🚀 Feature

I'm asking that for R2Score num_outputs argument not be required. Just like it isn't required for ExplainedVariance.

Motivation

There are situations where (e.g. CNN image to image, or generic LightningModule parent class) where I won't know the number of outputs in advance which makes the class impossible to use.

Pitch

It isn't really necessary to ask for it b/c ExplainedVariance doesn't.
Just do whatever ExplainedVariance does to avoid requiring the number of outputs in advance.

@profPlum profPlum added the enhancement New feature or request label Aug 29, 2024
Copy link

Hi! thanks for your contribution!, great first issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants