From 86356dcb179418f7f6efe9df8380f4437baad5aa Mon Sep 17 00:00:00 2001 From: SeanNaren Date: Mon, 15 Feb 2021 22:42:27 +0000 Subject: [PATCH 1/2] Add hydra fix that was missing from master --- pytorch_lightning/plugins/training_type/ddp.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pytorch_lightning/plugins/training_type/ddp.py b/pytorch_lightning/plugins/training_type/ddp.py index 52a24655f0846..11875a345c153 100644 --- a/pytorch_lightning/plugins/training_type/ddp.py +++ b/pytorch_lightning/plugins/training_type/ddp.py @@ -159,6 +159,8 @@ def _call_children_scripts(self): if _HYDRA_AVAILABLE: if HydraConfig.initialized(): cwd = get_original_cwd() + os_cwd = f'"{os.getcwd()}"' + command += [f'"hydra.run.dir={os_cwd}"', f'hydra.job.name=train_ddp_process_{local_rank}'] proc = subprocess.Popen(command, env=env_copy, cwd=cwd) self.interactive_ddp_procs.append(proc) From 7004dabda442eb27ce2b0bd144f69d7171d8d74a Mon Sep 17 00:00:00 2001 From: SeanNaren Date: Mon, 15 Feb 2021 22:54:11 +0000 Subject: [PATCH 2/2] Remove error commas --- pytorch_lightning/plugins/training_type/ddp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytorch_lightning/plugins/training_type/ddp.py b/pytorch_lightning/plugins/training_type/ddp.py index 11875a345c153..e5630ec980db1 100644 --- a/pytorch_lightning/plugins/training_type/ddp.py +++ b/pytorch_lightning/plugins/training_type/ddp.py @@ -160,7 +160,7 @@ def _call_children_scripts(self): if HydraConfig.initialized(): cwd = get_original_cwd() os_cwd = f'"{os.getcwd()}"' - command += [f'"hydra.run.dir={os_cwd}"', f'hydra.job.name=train_ddp_process_{local_rank}'] + command += [f'hydra.run.dir={os_cwd}', f'hydra.job.name=train_ddp_process_{local_rank}'] proc = subprocess.Popen(command, env=env_copy, cwd=cwd) self.interactive_ddp_procs.append(proc)