From 160f8cfc344f369eebff107feb0c534721c75f50 Mon Sep 17 00:00:00 2001 From: Jirka B Date: Mon, 19 May 2025 15:24:12 +0200 Subject: [PATCH 1/4] ci: debug failing run on master --- .github/workflows/_legacy-checkpoints.yml | 6 +++++- .github/workflows/release-pkg.yml | 18 +++++++++--------- .../{tpu-tests.yml.disabled => tpu-tests.yml} | 0 3 files changed, 14 insertions(+), 10 deletions(-) rename .github/workflows/{tpu-tests.yml.disabled => tpu-tests.yml} (100%) diff --git a/.github/workflows/_legacy-checkpoints.yml b/.github/workflows/_legacy-checkpoints.yml index 1df733aca34f2..1b699d5d26753 100644 --- a/.github/workflows/_legacy-checkpoints.yml +++ b/.github/workflows/_legacy-checkpoints.yml @@ -111,9 +111,13 @@ jobs: retention-days: ${{ env.KEEP_DAYS }} include-hidden-files: true + - name: access secrets + # export to env bool if secrets.AWS_REGION is not empty + run: echo "WITH_SECRETS=$([ -n '${{ secrets.AWS_REGION }}' ] && echo 0 || echo 1)" >> $GITHUB_ENV + - run: pip install -r requirements/ci.txt - name: Upload checkpoints to S3 - if: ${{ secrets[AWS_REGION] != '' }} + if: ${{ env.WITH_SECRETS == '1' }} working-directory: ${{ env.LEGACY_FOLDER }} env: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }} diff --git a/.github/workflows/release-pkg.yml b/.github/workflows/release-pkg.yml index 944e69476a358..348d4ce753117 100644 --- a/.github/workflows/release-pkg.yml +++ b/.github/workflows/release-pkg.yml @@ -179,12 +179,12 @@ jobs: with: pkg-folder: dist/${{ steps.folder.outputs.pkg }} pypi-token: ${{ secrets[format('PYPI_TOKEN_{0}', matrix.name)] }} -# FIXME: this is not working suddenly, Unrecognized named-value: 'secrets' -# legacy-checkpoints: -# needs: [build-packages] -# uses: ./.github/workflows/_legacy-checkpoints.yml -# with: -# push_to_s3: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }} -# upload_local: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }} -# create_pr: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }} -# secrets: inherit + + legacy-checkpoints: + needs: [build-packages] + uses: ./.github/workflows/_legacy-checkpoints.yml + with: + push_to_s3: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }} + upload_local: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }} + create_pr: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }} + secrets: inherit diff --git a/.github/workflows/tpu-tests.yml.disabled b/.github/workflows/tpu-tests.yml similarity index 100% rename from .github/workflows/tpu-tests.yml.disabled rename to .github/workflows/tpu-tests.yml From 1ee8e86aef98ee68dfbbaaff47ed0ad9b8379ba7 Mon Sep 17 00:00:00 2001 From: Jirka B Date: Tue, 20 May 2025 13:31:26 +0200 Subject: [PATCH 2/4] rename --- .../workflows/{ci-checkpoints.yml.disabled => ci-checkpoints.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{ci-checkpoints.yml.disabled => ci-checkpoints.yml} (100%) diff --git a/.github/workflows/ci-checkpoints.yml.disabled b/.github/workflows/ci-checkpoints.yml similarity index 100% rename from .github/workflows/ci-checkpoints.yml.disabled rename to .github/workflows/ci-checkpoints.yml From 3ae8baed39876dbb88bb26595bd7df1164f3d566 Mon Sep 17 00:00:00 2001 From: Jirka B Date: Mon, 16 Jun 2025 23:57:39 +0200 Subject: [PATCH 3/4] echo 1 || echo 0 --- .github/workflows/_legacy-checkpoints.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/_legacy-checkpoints.yml b/.github/workflows/_legacy-checkpoints.yml index 1b699d5d26753..a5ef99ef9e267 100644 --- a/.github/workflows/_legacy-checkpoints.yml +++ b/.github/workflows/_legacy-checkpoints.yml @@ -113,7 +113,7 @@ jobs: - name: access secrets # export to env bool if secrets.AWS_REGION is not empty - run: echo "WITH_SECRETS=$([ -n '${{ secrets.AWS_REGION }}' ] && echo 0 || echo 1)" >> $GITHUB_ENV + run: echo "WITH_SECRETS=$([ -n '${{ secrets.AWS_REGION }}' ] && echo 1 || echo 0)" >> $GITHUB_ENV - run: pip install -r requirements/ci.txt - name: Upload checkpoints to S3 From f1f124b3437d92019ed6a8b0d9708388975d5b26 Mon Sep 17 00:00:00 2001 From: Jirka B Date: Tue, 17 Jun 2025 10:47:17 +0200 Subject: [PATCH 4/4] gc --- .github/checkgroup.yml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 5269704f40698..5564879229f08 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -176,14 +176,15 @@ subprojects: - "lightning-fabric (GPUs) (testing Fabric | latest)" - "lightning-fabric (GPUs) (testing Lightning | latest)" - - id: "lightning_fabric: TPU workflow" - paths: - # tpu CI availability is very limited, so we only require tpu tests - # to pass when their configurations are modified - - ".github/workflows/tpu-tests.yml" - - "tests/tests_fabric/run_tpu_tests.sh" - checks: - - "test-on-tpus (pytorch, pjrt, v4-8)" + # Temporarily disabled + # - id: "lightning_fabric: TPU workflow" + # paths: + # # tpu CI availability is very limited, so we only require tpu tests + # # to pass when their configurations are modified + # - ".github/workflows/tpu-tests.yml" + # - "tests/tests_fabric/run_tpu_tests.sh" + # checks: + # - "test-on-tpus (pytorch, pjrt, v4-8)" # SECTION: common