Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting max_time in trainer triggers deprecation warning #9346

Closed
manuel-munoz-aguirre opened this issue Sep 6, 2021 · 2 comments · Fixed by #9347
Closed

Setting max_time in trainer triggers deprecation warning #9346

manuel-munoz-aguirre opened this issue Sep 6, 2021 · 2 comments · Fixed by #9347
Labels
bug Something isn't working deprecation Includes a deprecation help wanted Open to be worked on
Milestone
pl:1.4.x

Comments

@manuel-munoz-aguirre
Copy link

🐛 Bug

Setting max_time in Trainer triggers a deprecation warning:

/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/callback_hook.py:103: LightningDeprecationWarning: The signature of `Callback.on_train_epoch_end` has changed in v1.3. `outputs` parameter has been removed. Support for the old signature will be removed in v1.5
  "The signature of `Callback.on_train_epoch_end` has changed in v1.3."

To Reproduce

Reproduced by adding the max_time flag in the BoringModel notebook.

Expected behavior

No warning should appear.

Environment

  • CUDA:
    - GPU:
    - available: False
    - version: 10.2
  • Packages:
    - numpy: 1.19.0
    - pyTorch_debug: False
    - pyTorch_version: 1.9.0+cu102
    - pytorch-lightning: 1.4.5
    - tqdm: 4.62.2
@manuel-munoz-aguirre manuel-munoz-aguirre added bug Something isn't working help wanted Open to be worked on labels Sep 6, 2021
@awaelchli awaelchli mentioned this issue Sep 6, 2021
Merged
12 tasks
@awaelchli awaelchli added the deprecation Includes a deprecation label Sep 6, 2021
@awaelchli awaelchli added this to the v1.4.x milestone Sep 6, 2021
@awaelchli awaelchli linked a pull request Sep 6, 2021 that will close this issue
fix signature in callbacks to prevent deprecation warning #9347
Merged
12 tasks
@kaushikb11
Copy link
Contributor

Umm, Why didn't this issue close automatically after the PR getting merged lol? @awaelchli

@awaelchli
Copy link
Contributor

It should have, no idea why. Thanks for taking care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working deprecation Includes a deprecation help wanted Open to be worked on
Projects
None yet
Milestone
pl:1.4.x
Development

Successfully merging a pull request may close this issue.

fix signature in callbacks to prevent deprecation warning Lightning-AI/pytorch-lightning
3 participants
@awaelchli @manuel-munoz-aguirre @kaushikb11