Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .test() on ddp #885

Closed
williamFalcon opened this issue Feb 17, 2020 · 3 comments · Fixed by #1017
Closed

Fix .test() on ddp #885

williamFalcon opened this issue Feb 17, 2020 · 3 comments · Fixed by #1017
Labels
bug Something isn't working help wanted Open to be worked on

Comments

@williamFalcon
Copy link
Contributor

This might be broken on notebooks only.
#875 solves a few problems with .test()

However, ddp + .test might be broken on notebooks because of the "spawn" option. (likely #747).

@williamFalcon williamFalcon added bug Something isn't working help wanted Open to be worked on labels Feb 17, 2020
@williamFalcon
Copy link
Contributor Author

williamFalcon commented Feb 17, 2020

Anyone interested in looking at this?
@Borda

@sneiman
Copy link
Contributor

sneiman commented Feb 17, 2020

I am investigating this. Thats how I ran into the spawn issue with shared Q's. I am not using a notebook. This is (I believe) because ddp reduces tensors and parameters back to dev_ids[0] and there is no obvious way to get them back to the spawning CPU. I am slowly making progress, but don't have a lot of consistent time to put in.

@s-rog
Copy link
Contributor

s-rog commented Feb 24, 2020

Isn't ddp broken in notebooks in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Open to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants