You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some loggers (like TensorBoardLogger) require flushing/finalize to be called for logged metrics to be properly written to disk. However, finalize is not currently called after test/predict runs.
This manifests in metrics failing to be logged if .test or .predict is run on Trainer with a TensorBoardLogger.
🐛 Bug
Some loggers (like
TensorBoardLogger
) require flushing/finalize
to be called for logged metrics to be properly written to disk. However,finalize
is not currently called after test/predict runs.This manifests in metrics failing to be logged if
.test
or.predict
is run on Trainer with aTensorBoardLogger
.I believe this could be fixed with an extra
.finalize
call (like what is already in https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/loops/fit_loop.py#L265-L266) inEvaluationLoop
andPredictionLoop
. I'm not entirely sure if adding this would cause any issues though, so I'm a bit hesitant to submit a PR myself.To Reproduce
https://colab.research.google.com/drive/14j7qCoy33y4giqjA8xNfNMCK81F_OvFH?usp=sharing
Expected behavior
Metrics should be logged, regardless of whether
.fit
,.test
, or.predict
is called.Environment
The text was updated successfully, but these errors were encountered: