Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install pytorch-lightning["extra"] doesn't install FairScale #5093

Closed
mees opened this issue Dec 11, 2020 · 4 comments
Closed

pip install pytorch-lightning["extra"] doesn't install FairScale #5093

mees opened this issue Dec 11, 2020 · 4 comments
Labels
3rd party Related to a 3rd-party bug Something isn't working docs Documentation related help wanted Open to be worked on won't fix This will not be worked on

Comments

@mees
Copy link
Contributor

mees commented Dec 11, 2020

🐛 Bug

The documentation [0] states that to enable sharded training one needs to install the extras packages with pip install pytorch-lightning["extra"], in my case only following the second option pip install https://github.com/PyTorchLightning/fairscale/archive/pl_1.1.0.zip actually installed fairscale.

[0] https://pytorch-lightning.readthedocs.io/en/stable/multi_gpu.html#model-parallelism-beta

To Reproduce

pip install pytorch-lightning["extra"]

Expected behavior

Fairscale gets installed.

Environment

  • PyTorch Version 1.7.0
  • OS: Linux
  • How you installed PyTorch: pip
  • Python version: 3.6.9
  • CUDA/cuDNN version: 10.2
  • GPU models and configuration: 4x TITAN X
@mees mees added bug Something isn't working help wanted Open to be worked on labels Dec 11, 2020
@github-actions
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@hassiahk
Copy link
Contributor

hassiahk commented Dec 11, 2020

I just checked this, FairScale is not getting installed through pip install pytorch-lightning["extra"]. I also had to do pip install https://github.com/PyTorchLightning/fairscale/archive/pl_1.1.0.zip.

My Environment

  • PyTorch Version: 1.7.0
  • OS: Linux
  • How you installed PyTorch: pip
  • Python version: 3.8.5

@Borda
Copy link
Member

Borda commented Dec 11, 2020

true, we skip all HTTP paths from packages...
https://github.com/PyTorchLightning/pytorch-lightning/blob/ddc3757309e367ee8d67e2aabde2e6e46045572d/pytorch_lightning/setup_tools.py#L51
there is some problem on PyPI side if they are passed to these dependencies...
eventually, we can install it with git+https://...

@Borda Borda added the 3rd party Related to a 3rd-party label Dec 11, 2020
@Borda Borda added the docs Documentation related label Dec 11, 2020
@stale
Copy link

stale bot commented Jan 11, 2021

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Jan 11, 2021
@stale stale bot closed this as completed Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working docs Documentation related help wanted Open to be worked on won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants