Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Update reload_dataloaders_every_epoch to reload_dataloaders_every_n_epoch #5001

Closed
rohitgr7 opened this issue Dec 7, 2020 · 2 comments · Fixed by #5043
Closed
Labels
data handling Generic data-related topic feature Is an improvement or enhancement good first issue Good for newcomers priority: 2 Low priority task

Comments

@rohitgr7
Copy link
Contributor

rohitgr7 commented Dec 7, 2020

🚀 Feature

reload_dataloaders_every_epoch reloads dataloader every epoch. We can change it to reload dataloaders after every n epochs. It will accept both bool and int values. True will be treated as 1 and False will be treated as 0 (means no reload).

Motivation

Recently a request came up on slack regarding reloading dataloaders after some epochs. Also since we have enhanced fast_dev_run like this, we can update this too.

Alternatives

Can be done manually by calling the method to reload dataloaders with a simple conditional statement by setting reload_dataloaders_every_epoch=False, but we can let this attribute accept an integer to avoid manual work.

@rohitgr7 rohitgr7 added feature Is an improvement or enhancement help wanted Open to be worked on data handling Generic data-related topic good first issue Good for newcomers and removed help wanted Open to be worked on labels Dec 7, 2020
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Dec 7, 2020

cc @PyTorchLightning/core-contributors is this a good feature to have??

@stale
Copy link

stale bot commented Jan 6, 2021

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Jan 6, 2021
@rohitgr7 rohitgr7 added this to the 1.2 milestone Jan 7, 2021
@stale stale bot removed the won't fix This will not be worked on label Jan 7, 2021
@edenlightning edenlightning modified the milestones: 1.2, 1.3 Feb 8, 2021
@edenlightning edenlightning added the priority: 2 Low priority task label Apr 27, 2021
@edenlightning edenlightning modified the milestones: v1.3, v1.4 Apr 27, 2021
@edenlightning edenlightning removed this from the v1.4 milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data handling Generic data-related topic feature Is an improvement or enhancement good first issue Good for newcomers priority: 2 Low priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants