Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AttributeError] Multiple validation dataloaders #4245

Closed
tchaton opened this issue Oct 20, 2020 · 2 comments
Closed

[AttributeError] Multiple validation dataloaders #4245

tchaton opened this issue Oct 20, 2020 · 2 comments
Labels
bug Something isn't working help wanted Open to be worked on

Comments

@tchaton
Copy link
Contributor

tchaton commented Oct 20, 2020

🐛 Bug

Please reproduce using the BoringModel and post here

        for dl_idx, dl_metrics in enumerate(step_metrics):
            if len(dl_metrics) == 0:
                continue
            reduced_epoch_metrics = dl_metrics[0].__class__.reduce_on_epoch_end(dl_metrics)
            # make the keys 'k/dl'
            reduced_epoch_metrics = self.__rename_keys_by_dataloader_idx(reduced_epoch_metrics, dl_idx, num_loaders)
            # track the metrics
            logger_metrics = reduced_epoch_metrics.get_epoch_log_metrics()

with __rename_keys_by_dataloader_idx

AttributeError 'dict' object has no attribute 'get_epoch_log_metrics'

To Reproduce

Expected behavior

Environment

Please copy and paste the output from our
environment collection script
(or fill out the checklist below manually).

You can get the script and run it with:

wget https://raw.githubusercontent.com/PyTorchLightning/pytorch-lightning/master/tests/collect_env_details.py
# For security purposes, please check the contents of collect_env_details.py before running it.
python collect_env_details.py
  • PyTorch Version (e.g., 1.0):
  • OS (e.g., Linux):
  • How you installed PyTorch (conda, pip, source):
  • Build command you used (if compiling from source):
  • Python version:
  • CUDA/cuDNN version:
  • GPU models and configuration:
  • Any other relevant information:

Additional context

@tchaton tchaton added bug Something isn't working help wanted Open to be worked on labels Oct 20, 2020
@tchaton tchaton self-assigned this Oct 20, 2020
@tchaton tchaton changed the title multiple validation dataloaders [AttributeError] Multiple validation dataloaders Oct 20, 2020
@edenlightning
Copy link
Contributor

@tchaton update on this issue?

@edenlightning
Copy link
Contributor

This should be fixed in master, by the logging refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants