Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing callback hook for optimizer dicts #3496

Closed
edenlightning opened this issue Sep 15, 2020 · 2 comments
Closed

Add missing callback hook for optimizer dicts #3496

edenlightning opened this issue Sep 15, 2020 · 2 comments
Assignees
Labels
design Includes a design discussion feature Is an improvement or enhancement priority: 0 High priority task won't fix This will not be worked on

Comments

@edenlightning
Copy link
Contributor

Need a callback hook to consolidate the state of optimizer dicts before saving the final state_dict during model checkpointing.

@edenlightning edenlightning added bug Something isn't working feature Is an improvement or enhancement priority: 0 High priority task labels Sep 15, 2020
@ananthsub
Copy link
Contributor

this is blocked on #3545
For more context, I want to use https://github.com/facebookresearch/fairscale/blob/master/fairscale/optim/oss.py with Lightning. I have a callback that defines on_save_checkpoint to call the optimizer's consolidate_state_dict

however, this requires the callback to run in all workers to do the comms before we can save the optimizer state

@edenlightning edenlightning added design Includes a design discussion feature Is an improvement or enhancement and removed feature Is an improvement or enhancement bug Something isn't working labels Sep 22, 2020
@stale
Copy link

stale bot commented Nov 3, 2020

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Nov 3, 2020
@stale stale bot closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement priority: 0 High priority task won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants