Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics.sklearns don't work with DDP: Tensors must be CUDA and dense #3069

Closed
Erlemar opened this issue Aug 20, 2020 · 2 comments · Fixed by #2528
Closed

metrics.sklearns don't work with DDP: Tensors must be CUDA and dense #3069

Erlemar opened this issue Aug 20, 2020 · 2 comments · Fixed by #2528
Labels
bug Something isn't working help wanted Open to be worked on

Comments

@Erlemar
Copy link
Contributor

Erlemar commented Aug 20, 2020

🐛 Bug

Using sklearn-like metrics (from metrics.sklearns) works fine in DP mode, but results in the following error in DDP mode: Tensors must be CUDA and dense

To Reproduce

This colab notebook has a full example: https://colab.research.google.com/drive/1uxihs4pztF_qTN-gkO1QOaX0npzE_uSZ?usp=sharing

Mentioning @justusschock
@Erlemar Erlemar added bug Something isn't working help wanted Open to be worked on labels Aug 20, 2020
@Borda
Copy link
Member

Borda commented Aug 25, 2020

@SkafteNicki @justusschock mind have look? 🐰

@SkafteNicki
Copy link
Member

@Borda PR #2528 seems to solve it (tried out the colab notebook with that branch and error was gone). Could you please review so we can get it merged?

@SkafteNicki SkafteNicki mentioned this issue Aug 25, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New modular metric interface SkafteNicki/pytorch-lightning
3 participants
@Borda @Erlemar @SkafteNicki