-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make logging_mode (on_step
or on_epoch
) available to loggers
#20502
Comments
Hey @SiddhantSadangi, this is very reasonable. Would you like to send a PR? |
I can start working on it once I've some bandwidth. It can take a couple of months, though, due to present commitments :( |
That would be great @SiddhantSadangi! Of course, let's circle back in a couple of weeks and see where you are in terms of bandwidth. BTW anyone interested in helping? |
I'll share this thread with a few Neptune users who had initially requested this. Meanwhile, can we add the |
In my case, the mentioned change in x-axis measure of the data points started appearing while upgrading lightning version from 2.0 to 2.2. Since this is making logs not comparable, I'm looking for
|
Description & Motivation
Lightning lets you log
on_step
, oron_epoch
. However, even when usingon_epoch
, the global step is logged on the x-axis, not the epoch number.Loggers can manually extract
epoch
from the logged metrics and pass that as thestep
. However, this would breakon_step
logging.Making the logging mode for a logging call available would let loggers conditionally use either the
global_step
orcurrent_epoch
as thestep
for that particular metric.Pitch
No response
Alternatives
No response
Additional context
No response
cc @lantiga @Borda
The text was updated successfully, but these errors were encountered: