Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this really a DataLoader? #10208

Closed
aazzolini opened this issue Oct 28, 2021 · 1 comment
Closed

Is this really a DataLoader? #10208

aazzolini opened this issue Oct 28, 2021 · 1 comment

Comments

@aazzolini
Copy link

aazzolini commented Oct 28, 2021

Isn't this just an Iterator that we can pipe from the original DataLoader iterator? Usually sub-classing specializes behavior, it shouldn't modify it . Maybe this is more like a decorator or something?

https://github.com/PyTorchLightning/pytorch-lightning/blob/c614cf0c3d7a252bfd01ff8516f9f42f1c1b055a/pytorch_lightning/lite/wrappers.py#L128

@tchaton
Copy link
Contributor

tchaton commented Oct 28, 2021

Dear @aazzolini,

This shouldn't be an issue. You are sending a mixed signal to the contributors. Let's move this directly on the PR review.

Closing for now.
Best,
T.C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants