You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally posted by aazzolini October 27, 2021
It looks completely out of place to me and misleading. I really like the simplicitly of LightningLite as a concrete class.
The run method here is completely out of place. The docstring is wrong, because nothing gets accelerated because it is inside the "run" function, no other places call the "run" method.
I believe it would be great if we could remove the "run" method from here and make LightingLite a concrete class.
Discussed in #10206
Originally posted by aazzolini October 27, 2021
It looks completely out of place to me and misleading. I really like the simplicitly of LightningLite as a concrete class.
The run method here is completely out of place. The docstring is wrong, because nothing gets accelerated because it is inside the "run" function, no other places call the "run" method.
I believe it would be great if we could remove the "run" method from here and make LightingLite a concrete class.
https://github.com/PyTorchLightning/pytorch-lightning/blob/c614cf0c3d7a252bfd01ff8516f9f42f1c1b055a/pytorch_lightning/lite/lite.py#L143
The text was updated successfully, but these errors were encountered: