Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we need a run() method #10207

Closed
aazzolini opened this issue Oct 28, 2021 Discussed in #10206 · 1 comment
Closed

Why do we need a run() method #10207

aazzolini opened this issue Oct 28, 2021 Discussed in #10206 · 1 comment

Comments

@aazzolini
Copy link

Discussed in #10206

Originally posted by aazzolini October 27, 2021
It looks completely out of place to me and misleading. I really like the simplicitly of LightningLite as a concrete class.
The run method here is completely out of place. The docstring is wrong, because nothing gets accelerated because it is inside the "run" function, no other places call the "run" method.

I believe it would be great if we could remove the "run" method from here and make LightingLite a concrete class.

https://github.com/PyTorchLightning/pytorch-lightning/blob/c614cf0c3d7a252bfd01ff8516f9f42f1c1b055a/pytorch_lightning/lite/lite.py#L143

@tchaton
Copy link
Contributor

tchaton commented Oct 28, 2021

Dear @aazzolini,

This shouldn't be an issue. You are sending a mixed signal to the contributors. Let's move this directly on the PR review.

Closing for now.
Best,
T.C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants