-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging messages to notify when FitLoop
stopping conditions are met
#9749
Merged
carmocca
merged 17 commits into
Lightning-AI:master
from
jinyoung-lim:bugfix/9636_warn-fit-loop-silent-stop
Jul 23, 2022
Merged
Add logging messages to notify when FitLoop
stopping conditions are met
#9749
carmocca
merged 17 commits into
Lightning-AI:master
from
jinyoung-lim:bugfix/9636_warn-fit-loop-silent-stop
Jul 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on but when max steps or epochs are met.
jinyoung-lim
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
September 29, 2021 05:49
for more information, see https://pre-commit.ci
Cannot add labels and such as I do not have permission (not a contributor yet). |
tchaton
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
rohitgr7
reviewed
Oct 12, 2021
carmocca
approved these changes
Jul 20, 2022
for more information, see https://pre-commit.ci
carmocca
changed the title
Added a warning and related unit tests for non-early-stopping condition but when max steps or epochs are met.
Add logging messages to notify when Jul 20, 2022
FitLoop
stopping conditions are met
rohitgr7
approved these changes
Jul 21, 2022
awaelchli
approved these changes
Jul 21, 2022
Codecov Report
@@ Coverage Diff @@
## master #9749 +/- ##
========================================
+ Coverage 49% 76% +28%
========================================
Files 327 327
Lines 25492 25549 +57
========================================
+ Hits 12452 19508 +7056
+ Misses 13040 6041 -6999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix for fit_loop silently stopping without a warning when trainer's early stopping condition is not met but max_epochs or max_steps are met.
This is to raise a caution to users who might be calling Trainer.fit() multiple times and earlier fitting loop meeting max_epochs or max_steps condition so stopping. Then the later fit would start and silently stop as max_epochs or max_steps are met.
Fixes #9636
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃