Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PyTorch 2.0 from the test matrix #20009

Merged
merged 14 commits into from
Jun 30, 2024
Merged

Drop PyTorch 2.0 from the test matrix #20009

merged 14 commits into from
Jun 30, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 24, 2024 •
edited
Loading

What does this PR do?

Removes support for PyTorch 2.0, to shift our support window with the PyTorch 2.4 release soon. In subsequent PRs I'll add testing for PyTorch 2.4.

Previous PR for reference: #19706

📚 Documentation preview 📚: https://pytorch-lightning--20009.org.readthedocs.build/en/20009/

cc @Borda @carmocca @justusschock @awaelchli

@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Jun 24, 2024
@awaelchli awaelchli modified the milestone: 2.4 Jun 24, 2024
@awaelchli awaelchli force-pushed the tests/remove-pytorch-2.1 branch from 07a06d0 to efa5da3 Compare June 24, 2024 16:34
@awaelchli awaelchli changed the title WIP: Remove support for PyTorch 2.1 Drop PyTorch 2.1 from the test matrix Jun 30, 2024
@awaelchli awaelchli marked this pull request as ready for review June 30, 2024 14:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 30, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.8, 2.1, oldest) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.2) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.3) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 2.1, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3) success ✅
pl-cpu (windows-2022, lightning, 3.8, 2.1, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.2) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.3) success ✅
pl-cpu (macOS-14, pytorch, 3.8, 2.1) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 2.1) success ✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success ✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py, tests/tests_pytorch/callbacks/test_throughput_monitor.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/strategies/test_model_parallel_integration.py, tests/tests_pytorch/trainer/flags/test_inference_mode.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py, tests/tests_pytorch/callbacks/test_throughput_monitor.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/strategies/test_model_parallel_integration.py, tests/tests_pytorch/trainer/flags/test_inference_mode.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, docs/source-fabric/advanced/compile.rst, docs/source-fabric/advanced/model_init.rst, requirements/fabric/base.txt, requirements/fabric/examples.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py, docs/source-pytorch/advanced/compile.rst, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1, 12.1.0) success ✅
build-cuda (3.10, 2.2, 12.1.0) success ✅
build-cuda (3.11, 2.1, 12.1.0) success ✅
build-cuda (3.11, 2.2, 12.1.0) success ✅
build-pl (3.10, 2.1, 12.1.0) success ✅
build-pl (3.10, 2.2, 12.1.0) success ✅
build-pl (3.11, 2.1, 12.1.0) success ✅
build-pl (3.11, 2.2, 12.1.0) success ✅

These checks are required after the changes to .github/workflows/docker-build.yml, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, requirements/fabric/base.txt, requirements/fabric/examples.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.8, 2.1, oldest) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.1) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
fabric-cpu (macOS-14, lightning, 3.10, 2.3) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 2.1, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 2.1, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
fabric-cpu (macOS-14, fabric, 3.8, 2.1) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 2.1) success ✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success ✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, tests/tests_fabric/conftest.py, tests/tests_fabric/plugins/precision/test_bitsandbytes.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/strategies/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/test_fabric.py, tests/tests_fabric/test_wrappers.py, tests/tests_fabric/utilities/test_init.py, tests/tests_fabric/utilities/test_throughput.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, tests/tests_fabric/conftest.py, tests/tests_fabric/plugins/precision/test_bitsandbytes.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/strategies/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/test_fabric.py, tests/tests_fabric/test_wrappers.py, tests/tests_fabric/utilities/test_init.py, tests/tests_fabric/utilities/test_throughput.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.11) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented Jun 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59%. Comparing base (5636fe4) to head (cee6c3e).
Report is 73 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5636fe4) and HEAD (cee6c3e). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (5636fe4) HEAD (cee6c3e)
pytest 26 22
examples 10 0
app 10 0
tpu 2 0
lightning_app 3 0
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #20009     +/-   ##
=========================================
- Coverage      72%      59%    -13%     
=========================================
  Files         427      422      -5     
  Lines       35505    35362    -143     
=========================================
- Hits        25573    20725   -4848     
- Misses       9932    14637   +4705

@awaelchli awaelchli changed the title Drop PyTorch 2.1 from the test matrix Drop PyTorch 2.0 from the test matrix Jun 30, 2024
@awaelchli awaelchli requested a review from ethanwharris as a code owner June 30, 2024 16:37
@github-actions github-actions bot added the ci Continuous Integration label Jun 30, 2024
@mergify mergify bot removed the has conflicts label Jun 30, 2024
@awaelchli awaelchli force-pushed the tests/remove-pytorch-2.1 branch from 053a288 to 1848d1c Compare June 30, 2024 20:47
@awaelchli awaelchli force-pushed the tests/remove-pytorch-2.1 branch from 1848d1c to fdedabf Compare June 30, 2024 21:09
@awaelchli awaelchli merged commit 14493c0 into master Jun 30, 2024
118 checks passed
@awaelchli awaelchli deleted the tests/remove-pytorch-2.1 branch June 30, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file dockers docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@awaelchli @Borda