Remove support for PyTorch 1.13 #19706

awaelchli · 2024-03-27T23:42:54Z

What does this PR do?

PyTorch has published the RC1 for 2.3 and the release is coming soon. This PR makes PyTorch 2.0 the minimum supported version, as we will soon add 2.3 support.

Previous PR: #19300

📚 Documentation preview 📚: https://pytorch-lightning--19706.org.readthedocs.build/en/19706/

cc @Borda @carmocca @justusschock @awaelchli

for more information, see https://pre-commit.ci

github-actions · 2024-03-27T23:43:55Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 2.0, oldest)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.1)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.2)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 2.0, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.2)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 2.0)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.0)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 2.0)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/fabric.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/load.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/types.py, src/lightning/fabric/wrappers.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/cli.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/optimizer.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/testing/_runif.py, src/lightning/pytorch/utilities/types.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/plugins/precision/test_fsdp.py, tests/tests_pytorch/strategies/test_common.py, tests/tests_pytorch/strategies/test_ddp.py, tests/tests_pytorch/strategies/test_ddp_integration.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/utilities/test_compile.py, tests/tests_pytorch/utilities/test_model_summary.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/cli.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/optimizer.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/testing/_runif.py, src/lightning/pytorch/utilities/types.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/plugins/precision/test_fsdp.py, tests/tests_pytorch/strategies/test_common.py, tests/tests_pytorch/strategies/test_ddp.py, tests/tests_pytorch/strategies/test_ddp_integration.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/utilities/test_compile.py, tests/tests_pytorch/utilities/test_model_summary.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/fabric.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/load.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/types.py, src/lightning/fabric/wrappers.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/fabric.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/load.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/types.py, src/lightning/fabric/wrappers.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/cli.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/optimizer.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/testing/_runif.py, src/lightning/pytorch/utilities/types.py.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/fabric.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/load.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/types.py, src/lightning/fabric/wrappers.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/cli.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/optimizer.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/testing/_runif.py, src/lightning/pytorch/utilities/types.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.10, 2.0, 11.8.0)	success	✅
build-cuda (3.10, 2.1, 12.1.0)	success	✅
build-cuda (3.10, 2.2, 12.1.0)	success	✅
build-cuda (3.11, 2.1, 12.1.0)	success	✅
build-cuda (3.11, 2.2, 12.1.0)	success	✅
build-pl (3.10, 2.0, 11.8.0)	success	✅
build-pl (3.10, 2.1, 12.1.0)	success	✅
build-pl (3.10, 2.2, 12.1.0)	success	✅
build-pl (3.11, 2.1, 12.1.0)	success	✅
build-pl (3.11, 2.2, 12.1.0)	success	✅

These checks are required after the changes to .github/workflows/docker-build.yml, dockers/release/Dockerfile, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 2.0, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.11, 2.1)	success	✅
fabric-cpu (macOS-11, lightning, 3.11, 2.2)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 2.0, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 2.0)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 2.0)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/fabric.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/load.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/types.py, src/lightning/fabric/wrappers.py, tests/tests_fabric/accelerators/test_cuda.py, tests/tests_fabric/plugins/precision/test_fsdp.py, tests/tests_fabric/strategies/test_ddp.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/strategies/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/strategies/test_strategy.py, tests/tests_fabric/strategies/test_xla_fsdp.py, tests/tests_fabric/strategies/test_xla_fsdp_integration.py, tests/tests_fabric/test_fabric.py, tests/tests_fabric/test_wrappers.py, tests/tests_fabric/utilities/test_load.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/fabric.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/load.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/types.py, src/lightning/fabric/wrappers.py, tests/tests_fabric/accelerators/test_cuda.py, tests/tests_fabric/plugins/precision/test_fsdp.py, tests/tests_fabric/strategies/test_ddp.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/strategies/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/strategies/test_strategy.py, tests/tests_fabric/strategies/test_xla_fsdp.py, tests/tests_fabric/strategies/test_xla_fsdp_integration.py, tests/tests_fabric/test_fabric.py, tests/tests_fabric/test_wrappers.py, tests/tests_fabric/utilities/test_load.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/fabric.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/load.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/types.py, src/lightning/fabric/wrappers.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/cli.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/optimizer.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/testing/_runif.py, src/lightning/pytorch/utilities/types.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.11)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/fabric.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/load.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/types.py, src/lightning/fabric/wrappers.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/cli.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/optimizer.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/testing/_runif.py, src/lightning/pytorch/utilities/types.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

for more information, see https://pre-commit.ci

codecov · 2024-03-28T00:18:29Z

Codecov Report

Attention: Patch coverage is 94.87179% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 59%. Comparing base (b9680a3) to head (aa1cb6d).

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #19706     +/-   ##
=========================================
- Coverage      83%      59%    -24%     
=========================================
  Files         424      419      -5     
  Lines       34930    34600    -330     
=========================================
- Hits        28819    20248   -8571     
- Misses       6111    14352   +8241

for more information, see https://pre-commit.ci

…ightning into feature/torch-2-0-minimum

carmocca

Thats a lot of removed code!

remove conditional logic for _TORCH_GREATER_EQUAL_2_0

c73dd6d

awaelchli changed the title ~~Remove support for PyTorch 1.13~~ WIP: Remove support for PyTorch 1.13 Mar 27, 2024

github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Mar 27, 2024

awaelchli marked this pull request as ready for review March 27, 2024 23:43

awaelchli requested review from carmocca, justusschock, williamFalcon, tchaton, Borda and lantiga as code owners March 27, 2024 23:43

awaelchli added this to the 2.3 milestone Mar 27, 2024

[pre-commit.ci] auto fixes from pre-commit.com hooks

41946c1

for more information, see https://pre-commit.ci

awaelchli added 4 commits March 28, 2024 00:44

add changelog

18a401c

runif

19242ed

remove test

79cf272

update CI

26ca09f

awaelchli requested a review from ethanwharris as a code owner March 28, 2024 00:04

awaelchli added the fun Staff contributions outside working hours - to differentiate from the "community" label label Mar 28, 2024

github-actions bot added ci Continuous Integration dockers labels Mar 28, 2024

pre-commit-ci bot and others added 2 commits March 28, 2024 00:04

[pre-commit.ci] auto fixes from pre-commit.com hooks

39d1dd4

for more information, see https://pre-commit.ci

undo docker change

bd2d2fa

awaelchli and others added 4 commits March 28, 2024 01:24

mypy

8a44675

update

4323520

docker

1f411a7

[pre-commit.ci] auto fixes from pre-commit.com hooks

5575524

for more information, see https://pre-commit.ci

awaelchli added 4 commits March 28, 2024 02:09

fix

d575157

Merge branch 'feature/torch-2-0-minimum' of github.com:Lightning-AI/l…

5111adf

…ightning into feature/torch-2-0-minimum

Merge branch 'master' into feature/torch-2-0-minimum

1523697

Merge branch 'master' into feature/torch-2-0-minimum

ff94cb1

awaelchli changed the title ~~WIP: Remove support for PyTorch 1.13~~ Remove support for PyTorch 1.13 Apr 26, 2024

carmocca approved these changes Apr 26, 2024

View reviewed changes

Borda approved these changes Apr 27, 2024

View reviewed changes

mergify bot added the ready PRs ready to be merged label Apr 27, 2024

lantiga approved these changes Apr 27, 2024

View reviewed changes

awaelchli and others added 3 commits April 27, 2024 05:31

skip compile test on python 3.8

1863d0c

Typing fixes - remove unneeded type overrides

90cbb62

skip compile test on python 3.8

02655a9

awaelchli force-pushed the feature/torch-2-0-minimum branch from c410d94 to 02655a9 Compare April 27, 2024 03:31

awaelchli added 2 commits April 27, 2024 05:54

ignore deepspeed install on MacOS

0b622b7

fix checkgroup

aa1cb6d

awaelchli merged commit 5e0e02b into master Apr 27, 2024
125 checks passed

awaelchli deleted the feature/torch-2-0-minimum branch April 27, 2024 05:24

awaelchli mentioned this pull request Apr 27, 2024

Avoid interactions through test artifacts #19821

Merged

tzuhanchang mentioned this pull request Jun 19, 2024

Fix the packages to a version we know works forever until we need to update. tzuhanchang/HyPER#50

Closed

awaelchli mentioned this pull request Jun 24, 2024

Drop PyTorch 2.0 from the test matrix #20009

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove support for PyTorch 1.13 #19706

Remove support for PyTorch 1.13 #19706

awaelchli commented Mar 27, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

codecov bot commented Mar 28, 2024 •

edited

Loading

carmocca left a comment

Remove support for PyTorch 1.13 #19706

Remove support for PyTorch 1.13 #19706

Conversation

awaelchli commented Mar 27, 2024 • edited by github-actions bot Loading

What does this PR do?

github-actions bot commented Mar 27, 2024 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

codecov bot commented Mar 28, 2024 • edited Loading

Codecov Report

carmocca left a comment

Choose a reason for hiding this comment

awaelchli commented Mar 27, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

codecov bot commented Mar 28, 2024 •

edited

Loading