Alternative mechanism to detect missing Fabric.backward() call
#19493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
commented
Feb 17, 2024
for more information, see https://pre-commit.ci
carmocca
reviewed
Feb 17, 2024
for more information, see https://pre-commit.ci
…tning into feature/backward-hook2
…tning into feature/backward-hook2
for more information, see https://pre-commit.ci
…tning into feature/backward-hook2
awaelchli
added
the
fun
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19493 +/- ##
=========================================
- Coverage 84% 58% -25%
=========================================
Files 424 419 -5
Lines 34912 34819 -93
=========================================
- Hits 29264 20364 -8900
- Misses 5648 14455 +8807 |
carmocca
reviewed
Feb 19, 2024
justusschock
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Alternative implementation of #19447 that handles an edge case found by @carmocca. Unfortunately, in this implementation we need to introduce a global variable
_in_fabric_backwardwhich I tried to avoid before but is unavoidable now.I extended the test with the new edge case.
📚 Documentation preview 📚: https://pytorch-lightning--19493.org.readthedocs.build/en/19493/
cc @Borda @carmocca @justusschock @awaelchli