-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix saving relative symlink for ModelCheckpoint callback #19303
Fix saving relative symlink for ModelCheckpoint callback #19303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sending the PR! Great work. I added the test as we discussed.
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19303 +/- ##
==========================================
- Coverage 84% 49% -35%
==========================================
Files 446 438 -8
Lines 37570 37417 -153
==========================================
- Hits 31383 18291 -13092
- Misses 6187 19126 +12939 |
Co-authored-by: shenmishajing <[email protected]>
Co-authored-by: shenmishajing <[email protected]>
What does this PR do?
Fixes #19294
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19303.org.readthedocs.build/en/19303/