Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving relative symlink for ModelCheckpoint callback #19303

Merged
merged 5 commits into from
Jan 20, 2024
Merged

Fix saving relative symlink for ModelCheckpoint callback #19303

merged 5 commits into from
Jan 20, 2024

Conversation

shenmishajing
Copy link
Contributor

@shenmishajing shenmishajing commented Jan 17, 2024

What does this PR do?

Fixes #19294

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19303.org.readthedocs.build/en/19303/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 17, 2024
@shenmishajing shenmishajing requested a review from Borda as a code owner January 17, 2024 16:17
@awaelchli awaelchli added bug Something isn't working callback: model checkpoint community This PR is from the community labels Jan 17, 2024
@awaelchli awaelchli added this to the 2.1.x milestone Jan 17, 2024
@awaelchli awaelchli changed the title fix(ModelCheckpoint): fix symlink bug for ModelCheckpoint callback Fix saving relative symlink for ModelCheckpoint callback Jan 17, 2024
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sending the PR! Great work. I added the test as we discussed.

@mergify mergify bot added the ready PRs ready to be merged label Jan 17, 2024
Copy link

gitguardian bot commented Jan 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@awaelchli awaelchli self-assigned this Jan 19, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Merging #19303 (d414025) into master (e89f46a) will decrease coverage by 35%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19303      +/-   ##
==========================================
- Coverage      84%      49%     -35%     
==========================================
  Files         446      438       -8     
  Lines       37570    37417     -153     
==========================================
- Hits        31383    18291   -13092     
- Misses       6187    19126   +12939     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working callback: model checkpoint community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The new symlink feature of ModelCheckpoint is broken when wrong link path
3 participants