Fix typo in kwarg in SpikeDetection #19282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbommar
requested review from
awaelchli,
carmocca and
justusschock
as code owners
awaelchli
added
bug
awaelchli
approved these changes
Jan 15, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19282 +/- ##
==========================================
- Coverage 82% 54% -28%
==========================================
Files 445 440 -5
Lines 37286 37188 -98
==========================================
- Hits 30726 20126 -10600
- Misses 6560 17062 +10502 |
carmocca
approved these changes
Jan 15, 2024
awaelchli
pushed a commit
that referenced
this pull request
Jan 30, 2024
lexierule
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct typo:
bad_bachtes->bad_batchesinkwargsSimple fix to resolve kwarg variable name.
Breaking Changes
.pop("bad_batches") or .pop("bad_bachtes")but I'll you decide.I didn't see any uses of the misspelled kwarg in other Lightning-AI repos.
📚 Documentation preview 📚: https://pytorch-lightning--19282.org.readthedocs.build/en/19282/