Fix parsing v100s in `get_available_flops` #18952

awaelchli · 2023-11-05T17:26:36Z

What does this PR do?

Fixes #18946

📚 Documentation preview 📚: https://pytorch-lightning--18952.org.readthedocs.build/en/18952/

cc @Borda @carmocca @justusschock @awaelchli

github-actions · 2023-11-05T17:27:02Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.12, oldest)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.12, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1)	success	✅

These checks are required after the changes to src/lightning/fabric/utilities/throughput.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to src/lightning/fabric/utilities/throughput.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to src/lightning/fabric/utilities/throughput.py.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to src/lightning/fabric/utilities/throughput.py.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.12, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.12, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1)	success	✅

These checks are required after the changes to src/lightning/fabric/utilities/throughput.py, tests/tests_fabric/utilities/test_throughput.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	success	✅

These checks are required after the changes to src/lightning/fabric/utilities/throughput.py, tests/tests_fabric/utilities/test_throughput.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/fabric/utilities/throughput.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.11)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to src/lightning/fabric/utilities/throughput.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

for more information, see https://pre-commit.ci

tests/tests_fabric/utilities/test_throughput.py

Co-authored-by: Carlos Mocholí <[email protected]>

carmocca · 2023-11-06T15:10:03Z

Changing the milestone since this is unreleased

codecov · 2023-11-06T15:13:16Z

Codecov Report

Merging #18952 (d8f1449) into master (3a86097) will decrease coverage by 23%.
Report is 7 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #18952     +/-   ##
=========================================
- Coverage      75%      53%    -23%     
=========================================
  Files         449      444      -5     
  Lines       36000    36009      +9     
=========================================
- Hits        27091    18989   -8102     
- Misses       8909    17020   +8111

fix

f775317

awaelchli requested review from carmocca and justusschock as code owners November 5, 2023 17:26

github-actions bot added the fabric lightning.fabric.Fabric label Nov 5, 2023

chlog

48c4a7e

awaelchli added bug Something isn't working fun Staff contributions outside working hours - to differentiate from the "community" label labels Nov 5, 2023

awaelchli added this to the 2.1.x milestone Nov 5, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

0361ad1

for more information, see https://pre-commit.ci

awaelchli commented Nov 6, 2023

View reviewed changes

tests/tests_fabric/utilities/test_throughput.py Show resolved Hide resolved

Borda approved these changes Nov 6, 2023

View reviewed changes

carmocca approved these changes Nov 6, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Nov 6, 2023

Apply suggestions from code review

5af3c1c

Co-authored-by: Carlos Mocholí <[email protected]>

carmocca modified the milestones: 2.1.x, 2.2 Nov 6, 2023

V100 sxm2

d8f1449

carmocca merged commit 195a3bf into master Nov 6, 2023
117 checks passed

carmocca deleted the bugfix/throughput-v100s branch November 6, 2023 20:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix parsing v100s in `get_available_flops` #18952

Fix parsing v100s in `get_available_flops` #18952

awaelchli commented Nov 5, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Nov 5, 2023 •

edited

Loading

carmocca commented Nov 6, 2023

codecov bot commented Nov 6, 2023 •

edited

Loading

Fix parsing v100s in get_available_flops #18952

Fix parsing v100s in get_available_flops #18952

Conversation

awaelchli commented Nov 5, 2023 • edited by github-actions bot Loading

What does this PR do?

github-actions bot commented Nov 5, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

carmocca commented Nov 6, 2023

codecov bot commented Nov 6, 2023 • edited Loading

Codecov Report

Fix parsing v100s in `get_available_flops` #18952

Fix parsing v100s in `get_available_flops` #18952

awaelchli commented Nov 5, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Nov 5, 2023 •

edited

Loading

codecov bot commented Nov 6, 2023 •

edited

Loading