Rename PrecisionPlugin -> Precision #18840

awaelchli · 2023-10-23T03:24:59Z

What does this PR do?

Shortens the names and makes them consistent with Fabric.
Example:

from lightning.pytorch.plugins import BitsandbytesPrecisionPlugin

becomes

from lightning.pytorch.plugins import BitsandbytesPrecision

Backward-compatibility is preserved, you can still import all previous names without a warning. The request was raised by @lantiga.

📚 Documentation preview 📚: https://pytorch-lightning--18840.org.readthedocs.build/en/18840/

cc @Borda @justusschock @awaelchli @carmocca

for more information, see https://pre-commit.ci

github-actions · 2023-10-23T23:24:56Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.12, oldest)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.12, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1)	success	✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/pytorch/_graveyard/__init__.py, src/lightning/pytorch/_graveyard/precision.py, src/lightning/pytorch/_graveyard/tpu.py, src/lightning/pytorch/callbacks/throughput_monitor.py, src/lightning/pytorch/plugins/__init__.py, src/lightning/pytorch/plugins/precision/__init__.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/bitsandbytes.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/double.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/plugins/precision/half.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/plugins/precision/transformer_engine.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/strategies/single_device.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py, tests/tests_pytorch/accelerators/test_cpu.py, tests/tests_pytorch/accelerators/test_xla.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/graveyard/__init__.py, tests/tests_pytorch/graveyard/test_precision.py, tests/tests_pytorch/models/test_ddp_fork_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/plugins/precision/test_all.py, tests/tests_pytorch/plugins/precision/test_amp.py, tests/tests_pytorch/plugins/precision/test_amp_integration.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_double.py, tests/tests_pytorch/plugins/precision/test_fsdp.py, tests/tests_pytorch/plugins/precision/test_half.py, tests/tests_pytorch/plugins/precision/test_transformer_engine.py, tests/tests_pytorch/plugins/precision/test_xla.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_common.py, tests/tests_pytorch/strategies/test_ddp.py, tests/tests_pytorch/strategies/test_deepspeed.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to src/lightning/pytorch/_graveyard/__init__.py, src/lightning/pytorch/_graveyard/precision.py, src/lightning/pytorch/_graveyard/tpu.py, src/lightning/pytorch/callbacks/throughput_monitor.py, src/lightning/pytorch/plugins/__init__.py, src/lightning/pytorch/plugins/precision/__init__.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/bitsandbytes.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/double.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/plugins/precision/half.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/plugins/precision/transformer_engine.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/strategies/single_device.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py, tests/tests_pytorch/accelerators/test_cpu.py, tests/tests_pytorch/accelerators/test_xla.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/graveyard/__init__.py, tests/tests_pytorch/graveyard/test_precision.py, tests/tests_pytorch/models/test_ddp_fork_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/plugins/precision/test_all.py, tests/tests_pytorch/plugins/precision/test_amp.py, tests/tests_pytorch/plugins/precision/test_amp_integration.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_double.py, tests/tests_pytorch/plugins/precision/test_fsdp.py, tests/tests_pytorch/plugins/precision/test_half.py, tests/tests_pytorch/plugins/precision/test_transformer_engine.py, tests/tests_pytorch/plugins/precision/test_xla.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_common.py, tests/tests_pytorch/strategies/test_ddp.py, tests/tests_pytorch/strategies/test_deepspeed.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/utilities/test_imports.py, src/lightning/fabric/plugins/precision/bitsandbytes.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/pytorch/_graveyard/__init__.py, src/lightning/pytorch/_graveyard/precision.py, src/lightning/pytorch/_graveyard/tpu.py, src/lightning/pytorch/callbacks/throughput_monitor.py, src/lightning/pytorch/plugins/__init__.py, src/lightning/pytorch/plugins/precision/__init__.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/bitsandbytes.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/double.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/plugins/precision/half.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/plugins/precision/transformer_engine.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/strategies/single_device.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to src/lightning/pytorch/_graveyard/__init__.py, src/lightning/pytorch/_graveyard/precision.py, src/lightning/pytorch/_graveyard/tpu.py, src/lightning/pytorch/callbacks/throughput_monitor.py, src/lightning/pytorch/plugins/__init__.py, src/lightning/pytorch/plugins/precision/__init__.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/bitsandbytes.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/double.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/plugins/precision/half.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/plugins/precision/transformer_engine.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/strategies/single_device.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py, docs/source-pytorch/api_references.rst, docs/source-pytorch/common/precision_expert.rst, docs/source-pytorch/common/precision_intermediate.rst, docs/source-pytorch/extensions/plugins.rst.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.12, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.12, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1)	success	✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, tests/tests_fabric/plugins/collectives/test_torch_collective.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	success	✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, tests/tests_fabric/plugins/collectives/test_torch_collective.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/pytorch/_graveyard/__init__.py, src/lightning/pytorch/_graveyard/precision.py, src/lightning/pytorch/_graveyard/tpu.py, src/lightning/pytorch/callbacks/throughput_monitor.py, src/lightning/pytorch/plugins/__init__.py, src/lightning/pytorch/plugins/precision/__init__.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/bitsandbytes.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/double.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/plugins/precision/half.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/plugins/precision/transformer_engine.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/strategies/single_device.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.11)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/pytorch/_graveyard/__init__.py, src/lightning/pytorch/_graveyard/precision.py, src/lightning/pytorch/_graveyard/tpu.py, src/lightning/pytorch/callbacks/throughput_monitor.py, src/lightning/pytorch/plugins/__init__.py, src/lightning/pytorch/plugins/precision/__init__.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/bitsandbytes.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/double.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/plugins/precision/half.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/plugins/precision/transformer_engine.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/strategies/parallel.py, src/lightning/pytorch/strategies/single_device.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

carmocca

Has there been any discussion about adding a deprecation message? (even if there's no removal date)

How will users know that they need to upgrade? Simply by looking at the newest docs?

src/lightning/pytorch/plugins/__init__.py

src/lightning/pytorch/_graveyard/__init__.py

src/lightning/pytorch/_graveyard/precision.py

for more information, see https://pre-commit.ci

awaelchli · 2023-10-28T22:08:22Z

Hey @lantiga could you tell us if you want a deprecation message for the old name, or not?

Borda · 2023-10-28T23:35:53Z

Hey @lantiga could you tell us if you want a deprecation message for the old name, or not?

I would suggest having it

lantiga · 2023-10-29T00:43:46Z

Ok let’s add the deprecation message, and let’s include this in the next patch release.

We won’t remove for the foreseeable future.

for more information, see https://pre-commit.ci

tests/tests_pytorch/deprecated_api/test_no_removal_version.py

carmocca

Just a heads up for conflicts with #18848

src/lightning/pytorch/_graveyard/precision.py

for more information, see https://pre-commit.ci

src/lightning/pytorch/callbacks/throughput_monitor.py

awaelchli added 3 commits October 23, 2023 04:43

rename precision_plugin.py -> precision.py

0f27c85

rename precision classes

90a3901

update doc

e35e356

github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Oct 23, 2023

awaelchli added this to the 2.2 milestone Oct 23, 2023

awaelchli added refactor plugin labels Oct 23, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

f6cc40e

for more information, see https://pre-commit.ci

awaelchli marked this pull request as ready for review October 23, 2023 23:24

awaelchli requested review from carmocca, justusschock, williamFalcon, tchaton, Borda, edenlightning and lantiga as code owners October 23, 2023 23:24

carmocca reviewed Oct 24, 2023

View reviewed changes

src/lightning/pytorch/plugins/__init__.py Outdated Show resolved Hide resolved

src/lightning/pytorch/_graveyard/__init__.py Show resolved Hide resolved

src/lightning/pytorch/_graveyard/precision.py Show resolved Hide resolved

awaelchli and others added 5 commits October 28, 2023 23:16

forgotten

b9c1fc7

Merge branch 'master' into refactor/precision-plugin-name

08c123e

deprecation

51810dd

x

5465369

[pre-commit.ci] auto fixes from pre-commit.com hooks

191ecc1

for more information, see https://pre-commit.ci

types

24a0d01

awaelchli added the fun Staff contributions outside working hours - to differentiate from the "community" label label Oct 28, 2023

awaelchli and others added 5 commits October 29, 2023 04:05

test

46024f6

deprecation tests

3ac6db1

add chlog

2f9a586

[pre-commit.ci] auto fixes from pre-commit.com hooks

6322804

for more information, see https://pre-commit.ci

rename

1004db9

awaelchli requested a review from carmocca October 29, 2023 03:26

awaelchli modified the milestones: 2.2, 2.1.x Oct 29, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

e171468

for more information, see https://pre-commit.ci

carmocca approved these changes Oct 30, 2023

View reviewed changes

tests/tests_pytorch/deprecated_api/test_no_removal_version.py Outdated Show resolved Hide resolved

Borda approved these changes Oct 30, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Oct 30, 2023

carmocca reviewed Oct 30, 2023

View reviewed changes

src/lightning/pytorch/_graveyard/precision.py Show resolved Hide resolved

Merge branch 'master' into refactor/precision-plugin-name

4eb40d3

awaelchli force-pushed the refactor/precision-plugin-name branch from a827012 to 4eb40d3 Compare October 30, 2023 17:45

awaelchli and others added 2 commits October 30, 2023 18:55

update throughput

75cf230

[pre-commit.ci] auto fixes from pre-commit.com hooks

d56f8e7

for more information, see https://pre-commit.ci

carmocca reviewed Oct 30, 2023

View reviewed changes

src/lightning/pytorch/callbacks/throughput_monitor.py Outdated Show resolved Hide resolved

awaelchli added 3 commits October 30, 2023 19:02

FabricPrecision

adc3cfe

update tests

7357e7c

unused imports

4f6ebaa

awaelchli requested a review from carmocca October 30, 2023 18:11

carmocca approved these changes Oct 30, 2023

View reviewed changes

flaky test

d6a8726

awaelchli merged commit 079544a into master Oct 30, 2023
117 checks passed

awaelchli deleted the refactor/precision-plugin-name branch October 30, 2023 20:53

awaelchli mentioned this pull request Nov 3, 2023

Weekly minor patch release 2.1.1 [rebase & merge] #18917

Merged

7 tasks

awaelchli added a commit that referenced this pull request Nov 3, 2023

Rename PrecisionPlugin -> Precision (#18840)

4209403

Borda pushed a commit that referenced this pull request Nov 3, 2023

Rename PrecisionPlugin -> Precision (#18840)

cff9a71

lantiga pushed a commit that referenced this pull request Nov 6, 2023

Rename PrecisionPlugin -> Precision (#18840)

89f4d18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename PrecisionPlugin -> Precision #18840

Rename PrecisionPlugin -> Precision #18840

awaelchli commented Oct 23, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Oct 23, 2023 •

edited

Loading

carmocca left a comment

awaelchli commented Oct 28, 2023

Borda commented Oct 28, 2023

lantiga commented Oct 29, 2023

carmocca left a comment

Rename PrecisionPlugin -> Precision #18840

Rename PrecisionPlugin -> Precision #18840

Conversation

awaelchli commented Oct 23, 2023 • edited by github-actions bot Loading

What does this PR do?

github-actions bot commented Oct 23, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

carmocca left a comment

Choose a reason for hiding this comment

awaelchli commented Oct 28, 2023

Borda commented Oct 28, 2023

lantiga commented Oct 29, 2023

carmocca left a comment

Choose a reason for hiding this comment

awaelchli commented Oct 23, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Oct 23, 2023 •

edited

Loading