Fix deletion of resumed checkpoints #18750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
bugfix/checkpoint-deleted
branch
from
7b768a5 to
e5e1e84
Compare
for more information, see https://pre-commit.ci
…bugfix/checkpoint-deleted
awaelchli
added
the
fun
awaelchli
commented
Oct 9, 2023
awaelchli
requested review from
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
carmocca
approved these changes
Oct 10, 2023
Co-authored-by: Carlos Mocholí <[email protected]>
This reverts commit aff3af7.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18750 +/- ##
==========================================
- Coverage 84% 49% -35%
==========================================
Files 439 431 -8
Lines 34368 34235 -133
==========================================
- Hits 28808 16831 -11977
- Misses 5560 17404 +11844 |
Borda
reviewed
Oct 10, 2023
Borda
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #17189
Fixes #16426
This change makes it so that ModelCheckpoint callback no longer deletes a checkpoint if it originates from a directory that is not a subpath of the ModelCheckpoint's dirpath. This is to prevent accidental deletion of checkpoints when resuming. Furthermore, we now also guarantee that the checkpoint passed to the
trainer.fit(..., ckpt_path=)never gets deleted, even if it would be subject to the save-top-k mechanism.📚 Documentation preview 📚: https://pytorch-lightning--18750.org.readthedocs.build/en/18750/
cc @Borda @carmocca @awaelchli