Save ModelCheckpoint's last.ckpt as symlink if possible
#18748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
callback: model checkpoint
fun
awaelchli
added
feature
awaelchli
changed the title
last.ckpt as a symlink in ModelCheckpointlast.ckpt as symlink
awaelchli
changed the title
last.ckpt as symlinklast.ckpt as symlink if possible
…feature/save-last-symlink
awaelchli
requested review from
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18748 +/- ##
==========================================
- Coverage 83% 49% -34%
==========================================
Files 439 431 -8
Lines 34469 34324 -145
==========================================
- Hits 28706 16871 -11835
- Misses 5763 17453 +11690 |
Co-authored-by: Carlos Mocholí <[email protected]>
for more information, see https://pre-commit.ci
carmocca
approved these changes
Oct 11, 2023
justusschock
approved these changes
Oct 11, 2023
mergify
bot
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #18670
Fixes #14973
Part of #4335
This PR changes the ModelCheckpoint's behavior when
save_last=True:save_top_k != 0, andsave_last=True, thenlast.ckptwill be a symlink to the latest top-k checkpointsave_top_k == 0, thenlast.ckptremains a regular checkpointThis improves the user experience of having a deterministic file name to load the last checkpoint. LLM checkpoints can be > 100 GB, and saving a copy everytime is not only time consuming but also wasting disk space.
cc @Borda @carmocca @awaelchli