Drop support for PyTorch 1.11 #18691

awaelchli · 2023-10-02T18:42:18Z

What does this PR do?

With support for the new PyTorch 2.1 version, we're removing PyTorch 1.11 support too keep our 4-version support window (1.12, 1.13, 2.0, 2.1).

Previous PR: #16492

cc @carmocca @Borda @justusschock @awaelchli

for more information, see https://pre-commit.ci

…ature/drop-torch-1-11

README.md

github-actions · 2023-10-02T19:58:26Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.12, oldest)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.12, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/imports.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/trainer.py, tests/tests_pytorch/callbacks/test_finetuning_callback.py, tests/tests_pytorch/callbacks/test_stochastic_weight_avg.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/models/test_onnx.py, tests/tests_pytorch/plugins/precision/test_all.py, tests/tests_pytorch/plugins/precision/test_fsdp.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/strategies/test_registry.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
[pytorch-lightning (GPUs) (testing Lightning	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=177532&view=logs&jobId=47e66f3c-897a-5428-da11-bf5c7745762e)	success
[pytorch-lightning (GPUs) (testing PyTorch	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=177532&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f)	success

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/trainer.py, tests/tests_pytorch/callbacks/test_finetuning_callback.py, tests/tests_pytorch/callbacks/test_stochastic_weight_avg.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/models/test_onnx.py, tests/tests_pytorch/plugins/precision/test_all.py, tests/tests_pytorch/plugins/precision/test_fsdp.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/strategies/test_registry.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/utilities/test_imports.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/imports.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/trainer.py, tests/parity_fabric/utils.py.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/imports.py, requirements/fabric/base.txt, requirements/fabric/examples.txt.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/trainer.py, docs/source-pytorch/versioning.rst, requirements/pytorch/base.txt, requirements/pytorch/examples.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.12, 11.7.1)	success	✅
build-cuda (3.9, 1.13, 11.8.0)	success	✅
build-cuda (3.9, 1.13, 12.0.1)	success	✅
build-cuda (3.10, 2.0, 11.8.0)	success	✅
build-cuda (3.10, 2.0, 12.0.1)	success	✅
build-pl (3.9, 1.12, 11.7.1)	success	✅
build-pl (3.9, 1.13, 11.8.0)	success	✅
build-pl (3.9, 1.13, 12.0.1)	success	✅
build-pl (3.10, 2.0, 11.8.0)	success	✅
build-pl (3.10, 2.0, 12.0.1)	success	✅

These checks are required after the changes to dockers/release/Dockerfile, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/fabric/base.txt, requirements/fabric/examples.txt.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.12, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.12, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/imports.py, tests/tests_fabric/accelerators/test_cuda.py, tests/tests_fabric/accelerators/test_mps.py, tests/tests_fabric/plugins/precision/test_all.py, tests/tests_fabric/plugins/precision/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/strategies/test_registry.py, tests/tests_fabric/test_cli.py, tests/tests_fabric/test_connector.py, tests/tests_fabric/test_wrappers.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
[lightning-fabric (GPUs) (testing Fabric	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=177534&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f)	success
[lightning-fabric (GPUs) (testing Lightning	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=177534&view=logs&jobId=47e66f3c-897a-5428-da11-bf5c7745762e)	success

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/imports.py, tests/tests_fabric/accelerators/test_cuda.py, tests/tests_fabric/accelerators/test_mps.py, tests/tests_fabric/plugins/precision/test_all.py, tests/tests_fabric/plugins/precision/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/strategies/test_registry.py, tests/tests_fabric/test_cli.py, tests/tests_fabric/test_connector.py, tests/tests_fabric/test_wrappers.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/trainer.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.11)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/plugins/precision/fsdp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/overrides/distributed.py, src/lightning/pytorch/plugins/precision/fsdp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/trainer.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

codecov · 2023-10-03T16:39:01Z

Codecov Report

Merging #18691 (76cfc0c) into master (9d9220c) will decrease coverage by 29%.
The diff coverage is 100%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #18691     +/-   ##
=========================================
- Coverage      83%      55%    -29%     
=========================================
  Files         428      423      -5     
  Lines       33546    33409    -137     
=========================================
- Hits        27972    18273   -9699     
- Misses       5574    15136   +9562

Borda

over all lgtm, but would wait for @lantiga approval

.github/checkgroup.yml

requirements/fabric/base.txt

lantiga

Nice, love the simplifications that come with deprecating 1.11

adamjstewart · 2023-10-12T19:30:43Z

Typo in release notes: says 3.11 instead of 1.11

awaelchli · 2023-10-12T19:33:25Z

Thank you @adamjstewart
I updated it. You have really sharp eyes!

drop support for PyTorch 1.11

21c19a9

github-actions bot added ci Continuous Integration pl Generic label for PyTorch Lightning package labels Oct 2, 2023

awaelchli added 4 commits October 2, 2023 20:49

chlog

0c46fe6

remove dead code

13cda6b

remove runif decorations

9971327

more

beaf302

github-actions bot added the fabric lightning.fabric.Fabric label Oct 2, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

e546b0e

for more information, see https://pre-commit.ci

awaelchli added the refactor label Oct 2, 2023

awaelchli added this to the 2.1 milestone Oct 2, 2023

awaelchli added 4 commits October 2, 2023 21:41

fix missing import

fc1d14c

Merge remote-tracking branch 'origin/feature/drop-torch-1-11' into fe…

5f3f86d

…ature/drop-torch-1-11

readme

e7946bf

fix version

ec94989

awaelchli commented Oct 2, 2023

View reviewed changes

README.md Show resolved Hide resolved

awaelchli marked this pull request as ready for review October 2, 2023 19:57

awaelchli requested review from williamFalcon, lantiga, carmocca, justusschock, tchaton, Borda, edenlightning and ethanwharris as code owners October 2, 2023 19:57

awaelchli added 2 commits October 2, 2023 22:23

fix weird import issue

e250856

missed version bump

ca65771

mergify bot added the has conflicts label Oct 2, 2023

carmocca approved these changes Oct 3, 2023

View reviewed changes

carmocca mentioned this pull request Oct 3, 2023

Avoid importing bitsandbytes unless requested #18680

Merged

Merge branch 'master' into feature/drop-torch-1-11

76cfc0c

mergify bot removed the has conflicts label Oct 3, 2023

mergify bot added the has conflicts label Oct 3, 2023

Borda approved these changes Oct 3, 2023

View reviewed changes

.github/checkgroup.yml Show resolved Hide resolved

Merge branch 'master' into feature/drop-torch-1-11

d62bced

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 3, 2023

Borda reviewed Oct 3, 2023

View reviewed changes

requirements/fabric/base.txt Show resolved Hide resolved

lantiga approved these changes Oct 4, 2023

View reviewed changes

bump torchvision

3c91127

carmocca merged commit d31ef1f into master Oct 4, 2023
118 checks passed

carmocca deleted the feature/drop-torch-1-11 branch October 4, 2023 18:30

awaelchli mentioned this pull request Jan 17, 2024

Drop support for PyTorch 1.12 #19300

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop support for PyTorch 1.11 #18691

Drop support for PyTorch 1.11 #18691

awaelchli commented Oct 2, 2023 •

edited

Loading

github-actions bot commented Oct 2, 2023 •

edited

Loading

codecov bot commented Oct 3, 2023 •

edited

Loading

Borda left a comment

lantiga left a comment

adamjstewart commented Oct 12, 2023

awaelchli commented Oct 12, 2023

Drop support for PyTorch 1.11 #18691

Drop support for PyTorch 1.11 #18691

Conversation

awaelchli commented Oct 2, 2023 • edited Loading

What does this PR do?

github-actions bot commented Oct 2, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

codecov bot commented Oct 3, 2023 • edited Loading

Codecov Report

Borda left a comment

Choose a reason for hiding this comment

lantiga left a comment

Choose a reason for hiding this comment

adamjstewart commented Oct 12, 2023

awaelchli commented Oct 12, 2023

awaelchli commented Oct 2, 2023 •

edited

Loading

github-actions bot commented Oct 2, 2023 •

edited

Loading

codecov bot commented Oct 3, 2023 •

edited

Loading